feat: Resource monitor v1 readiness part 2 #3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for c40a23e55d9c928b9afcf38e00fad6bf61cdae10 |
sfc-gh-jmichalak
requested changes
Sep 12, 2024
pkg/acceptance/bettertestspoc/config/model/resource_monitor_model_gen.go
Outdated
Show resolved
Hide resolved
|
Integration tests failure for bcd583c658c9d23f0a84ab8e8cc448fd496c2205 |
sfc-gh-asawicki
requested changes
Sep 12, 2024
sfc-gh-asawicki
previously approved these changes
Sep 13, 2024
|
Integration tests failure for 86260ac3d983a3720e6db4eef73d31cb9f8d4aed |
sfc-gh-asawicki
previously approved these changes
Sep 13, 2024
sfc-gh-jmichalak
previously approved these changes
Sep 16, 2024
# Conflicts: # MIGRATION_GUIDE.md
sfc-gh-jcieslak
dismissed stale reviews from sfc-gh-jmichalak and sfc-gh-asawicki
via
e5b34ce
|
Integration tests cancelled for e5b34ce7316dfde561ec7d9ef8d064d25de14bfb |
sfc-gh-jmichalak
approved these changes
Sep 17, 2024
|
Integration tests failure for e5b34ce7316dfde561ec7d9ef8d064d25de14bfb |
sfc-gh-fbudzynski
pushed a commit
that referenced
this pull request
Sep 19, 2024
## Changes - Refactor data source - Update examples and documentation for resource and data source - Update examples for database role ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x] acceptance tests ## References <!-- issues documentation links, etc --> * [SHOW RESOURCE MONITORS](https://docs.snowflake.com/en/sql-reference/sql/show-resource-monitors)
sfc-gh-jmichalak
pushed a commit
that referenced
this pull request
Sep 19, 2024
🤖 I have created a release *beep* *boop* --- ## [0.96.0](v0.95.0...v0.96.0) (2024-09-18) Essential GA object readiness for V1: [link](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD) ([Roadmap reference](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#preparing-essential-ga-objects-for-the-provider-v1)). :exclamation: Migration guide: [v0.95.0 -> v0.96.0](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0950--v0960) ### 🎉 **What's new:** * V1 redesign of resources and data sources * Row access policy ([#3066](#3066)) ([#3063](#3063)) * Resource monitor ([#3052](#3052)) ([#3064](#3064)) * Masking policy ([#3078](#3078)) ([#3083](#3083)) * SDK upgrades * External volume ([#3033](#3033)) * Authentication policy ([#2937](#2937)) ([#3068](#3068)) ([#3061](#3061)) ### 🔧 **Misc** * Clean up old test object helpers ([#3049](#3049)) * Add example of granting role to multiple objects ([#3047](#3047)) * Update readme and objects rework state ([#3046](#3046)) ### 🐛 **Bug fixes:** * Fix model grants ([#3070](#3070)) * Fix database show by and resource logic ([#3055](#3055)) * Fix default secondary roles option import ([#3041](#3041)) * Fix sweepers for warehouse and database ([#3057](#3057)) * Fix views permadiff ([#3079](#3079)) * Update v0.95.0 migration guide ([#3062](#3062)) Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Test Plan
References