Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add stream on directory table #3129

Merged
merged 13 commits into from
Oct 22, 2024
Merged

feat: Add stream on directory table #3129

merged 13 commits into from
Oct 22, 2024

Conversation

sfc-gh-jmichalak
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak commented Oct 11, 2024

Test Plan

  • acceptance tests

References

https://docs.snowflake.com/en/sql-reference/sql/create-stream

TODO

  • add streams on views
  • add streams data source

Copy link

Integration tests failure for 6f6e10cc436ac95e18db086798c6e6fdf5e5b919

@sfc-gh-jmichalak sfc-gh-jmichalak marked this pull request as ready for review October 11, 2024 13:32
Copy link

Integration tests failure for 3d010870b2641217f9b98fa477e16584c96cb655

Copy link

Integration tests failure for 3fb35cd5aca0f1782dabf946d2fe5ef5f1c99f10

Copy link

Integration tests failure for 25dc08b10abc1f53ebcb547b5b3c60779614693b

Copy link

Integration tests failure for 949ecac9cc1b48648bc796f61e0fe1b9608fec99

docs/resources/stream_on_directory_table.md Outdated Show resolved Hide resolved
pkg/resources/diff_suppressions.go Show resolved Hide resolved
pkg/resources/stream_common.go Outdated Show resolved Hide resolved
pkg/resources/stream_common.go Outdated Show resolved Hide resolved
pkg/sdk/streams_impl_gen.go Show resolved Hide resolved
pkg/resources/stream_on_directory_table_acceptance_test.go Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
pkg/provider/resources/resources.go Outdated Show resolved Hide resolved
pkg/resources/stream_common.go Outdated Show resolved Hide resolved
pkg/resources/stream_common.go Outdated Show resolved Hide resolved
pkg/resources/stream_on_external_table.go Outdated Show resolved Hide resolved
Copy link

Integration tests failure for 95c61bcb0b53d7adbf574e29bebe77912a2db7e3

1 similar comment
Copy link

Integration tests failure for 95c61bcb0b53d7adbf574e29bebe77912a2db7e3

MIGRATION_GUIDE.md Show resolved Hide resolved
docs/resources/stream_on_directory_table.md Outdated Show resolved Hide resolved
pkg/resources/stream_common.go Outdated Show resolved Hide resolved
Copy link

Integration tests failure for d031de649d62975c7e035d2191ecf9e1c114eaf2

Copy link

Integration tests failure for 92137e6becc9c4e253e3c8f4259fdf1bea050cac

MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
docs/resources/stream_on_external_table.md Show resolved Hide resolved
pkg/resources/diff_suppressions.go Outdated Show resolved Hide resolved
pkg/resources/stream_common.go Outdated Show resolved Hide resolved
pkg/resources/stream_on_directory_table.go Show resolved Hide resolved
pkg/acceptance/helpers/stage_client.go Outdated Show resolved Hide resolved
pkg/sdk/testint/streams_gen_integration_test.go Outdated Show resolved Hide resolved
pkg/resources/stream_on_directory_table_acceptance_test.go Outdated Show resolved Hide resolved
Copy link

Integration tests failure for d4350dffd4f9a2afb07d73ed98b3de9fac93cb11

Copy link

Integration tests failure for 14830d944f9534bafb7dba2be31fdd47bb96bd15

Copy link

Integration tests failure for b8cc2e1a7866d665dc33bf68810d4b8c3c5db5e9

@sfc-gh-jmichalak sfc-gh-jmichalak merged commit 4391473 into main Oct 22, 2024
9 of 10 checks passed
@sfc-gh-jmichalak sfc-gh-jmichalak deleted the stream-v1 branch October 22, 2024 14:06
sfc-gh-jmichalak pushed a commit that referenced this pull request Nov 8, 2024
##
[0.98.0](v0.97.0...v0.98.0)
(2024-11-08)

Feature scope readiness for V1:
[link](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD)
([Roadmap
reference](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#wrap-up-the-functional-scope)).
:exclamation: Migration guide: [v0.97.0 ->
v0.98.0](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0970--v0980)

### 🎉 What's new
- New resources:
- authentication_policy
([#3098](#3098)),
references
[#2880](#2880)
- external_volume
([#3106](#3106)),
partially references
[#2980](#2980)
- stream_on_directory_table
([#3129](#3129))
- stream_on_view
([#3150](#3150))
- primary_connection, secondary_connection
([#3162](#3162))
- secret_with_basic_authentication, secret_with_generic_string,
secret_with_oauth_authorization_code_grant,
secret_with_oauth_client_credentials
([#3110](#3110)),
([#3141](#3141))
- New data sources:
- connections
([#3155](#3155)),
([#3173](#3173))
- secrets
([#3131](#3131))
- Reworked:
- provider configuration hierarchy
([#3166](#3166)),
references
[#1881](#1881),
[#2145](#2145),
[#2925](#2925),
[#2983](#2983),
[#3104](#3104)
- provider configuration fields
([#3152](#3152))
streams data source
([#3151](#3151))
- SDK upgrades:
- Upgrade tag SDK
([#3126](#3126))
- Recreate streams when they are stale
([#3129](#3129))
### 🔧  Misc
- Add object renaming research summary
([#3172](#3172))
- Test support for object renaming
([#3130](#3130)),
([#3147](#3147)),
([#3154](#3154))
- Add tests to issue
[#3117](#3117)
([#3133](#3133))
- New roadmap entry
([#3158](#3158))
- Test more authentication methods
([#3178](#3178))
- Minor fixes
([#3174](#3174))
### 🐛  Bug fixes
- Apply various fixes
([#3176](#3176)),
this addresses BCR 2024_08, references
[#2717](#2717),
[#3005](#3005),
[#3125](#3125),
[#3127](#3127),
[#3153](#3153)
- Connection and secret data sources tests
([#3177](#3177))
- Fix grant import docs
([#3183](#3183)),
resolves
[#3179](https://github.com/Snowflake-Labs/terraform-provider-snowflake/discussions/3179)
- Fix user resource import
([#3181](#3181))
- Handle external type changes in stream resources
([#3164](#3164))
- Do not use OR REPLACE on initial creation in resources with
copy_grants
([#3129](#3129))
- Address issue
[#2201](#2201)
by introducing new stream resources

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants