Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SDK Connection #3155

Merged
merged 17 commits into from
Oct 30, 2024
Merged

feat: SDK Connection #3155

merged 17 commits into from
Oct 30, 2024

Conversation

sfc-gh-fbudzynski
Copy link
Collaborator

@sfc-gh-fbudzynski sfc-gh-fbudzynski commented Oct 24, 2024

Info

  • ignore edition check has been removed since I can no longer execute an sql operation with it on snowflake
  • Syntax error: unexpected 'IGNORE'

Changes

  • connection sdk
  • connection snowflake object assertions

Test Plan

  • unit tests
  • integration tests

TODO

References

Copy link

Integration tests failure for fa3db2bc0cdd23f1f890a4c95a0497a8866e84b0

pkg/sdk/testint/connections_gen_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/testint/connections_gen_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/testint/connections_gen_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/connections_gen_test.go Outdated Show resolved Hide resolved
pkg/sdk/connections_def.go Outdated Show resolved Hide resolved
pkg/sdk/connections_def.go Outdated Show resolved Hide resolved
pkg/sdk/connections_def.go Outdated Show resolved Hide resolved
pkg/sdk/connections_def.go Show resolved Hide resolved
pkg/sdk/connections_def.go Show resolved Hide resolved
pkg/sdk/testint/connections_gen_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/testint/connections_gen_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/testint/connections_gen_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/connections_def.go Outdated Show resolved Hide resolved
pkg/sdk/connections_gen.go Show resolved Hide resolved
pkg/sdk/testint/connections_gen_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/connections_gen.go Outdated Show resolved Hide resolved
pkg/sdk/testint/connections_gen_integration_test.go Outdated Show resolved Hide resolved
pkg/sdk/testint/connections_gen_integration_test.go Outdated Show resolved Hide resolved
Copy link

Integration tests failure for b739e999758271a2295dd8b89ecfb3f9e38b7884

Copy link

Integration tests failure for d7b13de9a4e0f6739220aa8b8381dbe9149c232f

Copy link

Integration tests failure for f9c4f6a932073b3066a82519dc6633ca99566bb6

@sfc-gh-asawicki sfc-gh-asawicki merged commit bd11e0f into main Oct 30, 2024
8 of 9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the connection-sdk branch October 30, 2024 02:20
sfc-gh-fbudzynski added a commit that referenced this pull request Nov 7, 2024
<!-- Feel free to delete comments as you fill this in -->

<!-- summary of changes -->
## Changes
* connection resource
* connection documentation
* added connection to migration guide  
## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested
-->
* [x] acceptance tests
<!-- add more below if you think they are relevant -->

## TODO
* [Uncomment acceptance tests for
failover](https://snowflakecomputing.atlassian.net/browse/SNOW-1763442)
* [Unskip integration
tests](https://snowflakecomputing.atlassian.net/browse/SNOW-1002023)
* Datasource

## References
<!-- issues documentation links, etc  -->
* https://docs.snowflake.com/en/sql-reference/sql/create-connection
*
#3155
sfc-gh-jmichalak pushed a commit that referenced this pull request Nov 8, 2024
##
[0.98.0](v0.97.0...v0.98.0)
(2024-11-08)

Feature scope readiness for V1:
[link](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD)
([Roadmap
reference](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#wrap-up-the-functional-scope)).
:exclamation: Migration guide: [v0.97.0 ->
v0.98.0](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0970--v0980)

### 🎉 What's new
- New resources:
- authentication_policy
([#3098](#3098)),
references
[#2880](#2880)
- external_volume
([#3106](#3106)),
partially references
[#2980](#2980)
- stream_on_directory_table
([#3129](#3129))
- stream_on_view
([#3150](#3150))
- primary_connection, secondary_connection
([#3162](#3162))
- secret_with_basic_authentication, secret_with_generic_string,
secret_with_oauth_authorization_code_grant,
secret_with_oauth_client_credentials
([#3110](#3110)),
([#3141](#3141))
- New data sources:
- connections
([#3155](#3155)),
([#3173](#3173))
- secrets
([#3131](#3131))
- Reworked:
- provider configuration hierarchy
([#3166](#3166)),
references
[#1881](#1881),
[#2145](#2145),
[#2925](#2925),
[#2983](#2983),
[#3104](#3104)
- provider configuration fields
([#3152](#3152))
streams data source
([#3151](#3151))
- SDK upgrades:
- Upgrade tag SDK
([#3126](#3126))
- Recreate streams when they are stale
([#3129](#3129))
### 🔧  Misc
- Add object renaming research summary
([#3172](#3172))
- Test support for object renaming
([#3130](#3130)),
([#3147](#3147)),
([#3154](#3154))
- Add tests to issue
[#3117](#3117)
([#3133](#3133))
- New roadmap entry
([#3158](#3158))
- Test more authentication methods
([#3178](#3178))
- Minor fixes
([#3174](#3174))
### 🐛  Bug fixes
- Apply various fixes
([#3176](#3176)),
this addresses BCR 2024_08, references
[#2717](#2717),
[#3005](#3005),
[#3125](#3125),
[#3127](#3127),
[#3153](#3153)
- Connection and secret data sources tests
([#3177](#3177))
- Fix grant import docs
([#3183](#3183)),
resolves
[#3179](https://github.com/Snowflake-Labs/terraform-provider-snowflake/discussions/3179)
- Fix user resource import
([#3181](#3181))
- Handle external type changes in stream resources
([#3164](#3164))
- Do not use OR REPLACE on initial creation in resources with
copy_grants
([#3129](#3129))
- Address issue
[#2201](#2201)
by introducing new stream resources

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants