Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grant ownership follow-up #2658

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Mar 27, 2024

A follow-up for #2604.

Done in this pr:

  • All of the edge cases handled and tested (except of tasks that are done in the separate pr):
    • Materialized views (already handled by Snowflake no changes needed)
    • RBAC hierarchy (test case added)
    • Delete dependent resource (role or granted object) and remove grant resource from the state (test case added)

Won't do:

  • External tables (cannot handle this edge case, because we have to know the auto_refresh state of the external table; it's not retrievable by SHOW or DESC commands. It will be still possible to grant ownership of the external table, but there may be additional manual work to do afterward. Everything is documented.)

Test Plan

  • acceptance tests that show how the resource is handling certain edge cases + RBAC use case

References

GRANT OWNERSHIP

Mentioned in

A list of issues requesting this resource: #2549 #2199 #2084 #1942 #1875

Copy link

Integration tests failure for 155139a2857043f11f20568f560d0dc15f018cb7

@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review April 4, 2024 09:17
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the grant-ownership-follow-up-follow-up branch from 155139a to 697a93c Compare April 4, 2024 09:33
Copy link

github-actions bot commented Apr 4, 2024

Integration tests failure for 697a93cb162c59ba995970a6fedcb30cec334962

Copy link

github-actions bot commented Apr 4, 2024

Integration tests failure for bd1ef58a42fcdd111c9200c8930e563c58d89f04

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review April 5, 2024 11:32
Copy link

github-actions bot commented Apr 5, 2024

Integration tests failure for 99653b602e6a6e0fca702c7c025e49d102b7414c

Copy link

github-actions bot commented Apr 8, 2024

Integration tests failure for 8927b1542d1343f3fa5e5c3483ba80ecce7ed5e6

1 similar comment
Copy link

github-actions bot commented Apr 8, 2024

Integration tests failure for 8927b1542d1343f3fa5e5c3483ba80ecce7ed5e6

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review April 8, 2024 14:34
@sfc-gh-jcieslak sfc-gh-jcieslak merged commit bfa2317 into main Apr 8, 2024
8 of 9 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the grant-ownership-follow-up-follow-up branch April 8, 2024 14:49
Copy link

github-actions bot commented Apr 8, 2024

Integration tests failure for a2dcc875be5c85678934fbbd6e88d9bd25b2595b

sfc-gh-jcieslak pushed a commit that referenced this pull request Apr 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.88.0](v0.87.3-pre...v0.88.0)
(2024-04-09)


### 🎉 **What's new:**

* Fix issues 2651 2656
([#2659](#2659))
([7fa09cc](7fa09cc))
* Grant ownership follow up
([#2628](#2628))
([d467e5b](d467e5b))
* grant ownership follow-up
([#2658](#2658))
([bfa2317](bfa2317))
* grant ownership on tasks
([#2684](#2684))
([2ba7889](2ba7889))
* Introduce shared function to suspend task roots
([#2650](#2650))
([d684b5d](d684b5d))
* Redesign snowflake_grants datasource
([#2667](#2667))
([918873d](918873d))
* user password policy attachment
([#2627](#2627))
([382e49d](382e49d))


### 🔧 **Misc**

* release 0.88.0
([02d60e0](02d60e0))
* Update grant examples in all resources
([#2660](#2660))
([b542b69](b542b69))


### 🐛 **Bug fixes:**

* Adjust dynamic tables after BCR-1543
([#2664](#2664))
([cf32ceb](cf32ceb))
* Fix handling secure views read and import
([#2655](#2655))
([3c3ede6](3c3ede6))
* Fix issues 2606 2642 2652 2653
([#2654](#2654))
([4a73721](4a73721))
* Fix release workflow
([#2639](#2639))
([dfd07e9](dfd07e9))
* Generate docs for dynamic table
([#2666](#2666))
([16c75b0](16c75b0))
* grant read operation
([#2665](#2665))
([0b947a5](0b947a5))
* migration guide for databases created from share
([#2637](#2637))
([f9651bc](f9651bc))
* with_grant_option diff drift
([#2608](#2608))
([f0018c6](f0018c6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants