Skip to content

Commit

Permalink
fix missing junit
Browse files Browse the repository at this point in the history
Builds were failing because `junit` was not installed. Use a dedicated
action plugin to ensure it is available and also publish the test report
on PR's for convenient viewing. For now we don't create an actual PR
check, only annotations, because the check is currently sent to the
wrong build. See
mikepenz/action-junit-report#40.
  • Loading branch information
garfieldnate committed Dec 12, 2022
1 parent c105b76 commit efa12cf
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,6 @@ indent_size = 4
# no particular reason, just specifying how our files are currently formatted
[*.soar]
indent_size = 3

[*.yml]
indent_size = 2
27 changes: 25 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,18 @@ jobs:

- name: unit tests
working-directory: ./out
run: ./UnitTests -e PRIMS_Sanity1 -e PRIMS_Sanity2 -f testSmemArithmetic && junit TestResults.xml
run: ./UnitTests -e PRIMS_Sanity1 -e PRIMS_Sanity2 -f testSmemArithmetic

# reports JUnit test results as GitHub PR check.
- name: publish test report
uses: mikepenz/action-junit-report@v3
# always run even if the previous step fails
if: always()
with:
report_paths: './out/TestResults.xml'
# disabled until https://github.com/mikepenz/action-junit-report/issues/40 is resolved
# fail_on_failure: true
annotate_only: true
# TODO: run Python SML test

Windows:
Expand Down Expand Up @@ -96,5 +107,17 @@ jobs:

- name: unit tests
working-directory: ./out
run: ./UnitTests -e PRIMS_Sanity1 -e PRIMS_Sanity2 -f testSmemArithmetic && junit TestResults.xml
run: ./UnitTests -e PRIMS_Sanity1 -e PRIMS_Sanity2 -f testSmemArithmetic

# reports JUnit test results as GitHub PR check.
- name: publish test report
uses: mikepenz/action-junit-report@v3
# always run even if the previous step fails
if: always()
with:
report_paths: './out/TestResults.xml'
# disabled until https://github.com/mikepenz/action-junit-report/issues/40 is resolved
# fail_on_failure: true
annotate_only: true

# TODO: run Python SML test

0 comments on commit efa12cf

Please sign in to comment.