-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CircleCI builds for PRs from fork #67
Comments
You can define another trigger that is triggered by "pull request comment added" (it requires being repository owner/maintainer) for forks. For extra protection, you can specify the codefresh.yaml of the master branch in the pipeline to prevent tinkering with the yaml file. It's also possible to trigger a different pipeline that do the "promoting" of images on Dockerhub (from CF internal registry) and trigger it in another step via CF cli. (this pipeline can be completely private) |
All sound like a good suggestions :) Thanks! |
Look like Kubernetes CI Robot can help us with that by adding the |
I disabled them now because it's insecure - people can trigger builds that push images, or expose information. Need to investigate and decide how it is best to enable it again to test also PRs from a fork.
The text was updated successfully, but these errors were encountered: