Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On page TOC title missing from language strings #20

Open
Protonotarios opened this issue Feb 23, 2018 · 2 comments
Open

On page TOC title missing from language strings #20

Protonotarios opened this issue Feb 23, 2018 · 2 comments

Comments

@Protonotarios
Copy link

Protonotarios commented Feb 23, 2018

Hi! I've just added Greek translation #19 [EDIT: I've cancelled this and made a new pull request - see below]. The funny thing is that the reason I'd started translating in the first place was to translate just one string actually: the on page TOC title in frontend. But it's not there 😄

Can you please add it?

@Protonotarios
Copy link
Author

P.S. I just saw that another important frontend string is missing: "Permanent link:" in tooltip.
2018-02-23 13_01_21-screenshot png 872x702

@Protonotarios
Copy link
Author

Protonotarios commented Feb 24, 2018

I just added the title strings missing #21 on toc.html.twig. I hope it's ok given that I have just learned the very existence of twig! I am still working on the tooltip but it's a bit difficult for me since the language dependent replacements occur at the end of Toc.php while the tooltip is generated very early in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant