From abe7b44f8ca01596c09d261b4adecd6fe657a386 Mon Sep 17 00:00:00 2001
From: Tibor Blenessy <saberduck@users.noreply.github.com>
Date: Fri, 5 Apr 2024 18:58:05 +0200
Subject: [PATCH] Change min required Node.JS version to 18.17.0 (#4652)

---
 package-lock.json                                             | 2 +-
 package.json                                                  | 2 +-
 sonar-plugin/sonar-javascript-plugin/pom.xml                  | 2 +-
 .../plugins/javascript/bridge/NodeDeprecationWarning.java     | 4 ++--
 .../plugins/javascript/bridge/NodeDeprecationWarningTest.java | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index c4a7ac175e8..f5a4f88ad7b 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -123,7 +123,7 @@
         "typedoc": "0.25.12"
       },
       "engines": {
-        "node": "^18.17.1 || ^20.9.0 || >=21.1.0"
+        "node": "^18.17.0 || ^20.9.0 || >=21.1.0"
       }
     },
     "node_modules/@aashutoshrathi/word-wrap": {
diff --git a/package.json b/package.json
index 6cc62156346..08627e44440 100644
--- a/package.json
+++ b/package.json
@@ -40,7 +40,7 @@
   },
   "homepage": "https://github.com/SonarSource/SonarJS#readme",
   "engines": {
-    "node": "^18.17.1 || ^20.9.0 || >=21.1.0"
+    "node": "^18.17.0 || ^20.9.0 || >=21.1.0"
   },
   "type": "commonjs",
   "devDependencies": {
diff --git a/sonar-plugin/sonar-javascript-plugin/pom.xml b/sonar-plugin/sonar-javascript-plugin/pom.xml
index eb3a8b07bfc..e796503d5d7 100644
--- a/sonar-plugin/sonar-javascript-plugin/pom.xml
+++ b/sonar-plugin/sonar-javascript-plugin/pom.xml
@@ -312,7 +312,7 @@
                     <!-- This is used to get plugin version at runtime using getPackage().getImplementationVersion() -->
                     <Implementation-Version>${project.version}</Implementation-Version>
                     <!-- Keep in sync with NodeDeprecationWarning#MIN_SUPPORTED_NODE_VERSION -->
-                    <NodeJs-Min-Version>18.17.1</NodeJs-Min-Version>
+                    <NodeJs-Min-Version>18.17.0</NodeJs-Min-Version>
                   </manifestEntries>
                 </transformer>
               </transformers>
diff --git a/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/NodeDeprecationWarning.java b/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/NodeDeprecationWarning.java
index 4f06a6fc1e9..878bcb33005 100644
--- a/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/NodeDeprecationWarning.java
+++ b/sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/NodeDeprecationWarning.java
@@ -52,9 +52,9 @@ public class NodeDeprecationWarning {
    * <p>
    * The minor version is a requirement from the ESLint version that the bridge uses.
    */
-  static final Version MIN_SUPPORTED_NODE_VERSION = Version.create(18, 17, 1);
+  static final Version MIN_SUPPORTED_NODE_VERSION = Version.create(18, 17, 0);
   static final int MIN_RECOMMENDED_NODE_VERSION = 18;
-  static final List<Integer> RECOMMENDED_NODE_VERSIONS = Arrays.asList(18, 20);
+  static final List<String> RECOMMENDED_NODE_VERSIONS = List.of("^18.18.0", "^20.9.0");
   static final List<Integer> ALL_RECOMMENDED_NODE_VERSIONS = Arrays.asList(18, 20, 21);
   private final AnalysisWarningsWrapper analysisWarnings;
 
diff --git a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/NodeDeprecationWarningTest.java b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/NodeDeprecationWarningTest.java
index ed1a19e9d04..6ab0bc2a96c 100644
--- a/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/NodeDeprecationWarningTest.java
+++ b/sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/NodeDeprecationWarningTest.java
@@ -62,7 +62,7 @@ void test_recommended() {
   void test_19() {
     deprecationWarning.logNodeDeprecation(19);
     assertWarnings(
-      "Node.js version 19 is not recommended, you might experience issues. Please use a recommended version of Node.js [18, 20]"
+      "Node.js version 19 is not recommended, you might experience issues. Please use a recommended version of Node.js [^18.18.0, ^20.9.0]"
     );
   }