From fa6d38c1977044afea3ae09cebdc6f776a7f6c17 Mon Sep 17 00:00:00 2001
From: yassin-kammoun-sonarsource <yassin.kammoun@sonarsource.com>
Date: Tue, 21 Nov 2023 13:33:09 +0100
Subject: [PATCH] Improve S6855 (`media-has-caption`): Report on the name of
 the opening element

---
 packages/jsts/src/rules/S6855/cb.fixture.jsx |  4 +++
 packages/jsts/src/rules/S6855/cb.test.ts     | 28 +++++++++++++++++
 packages/jsts/src/rules/S6855/decorator.ts   | 33 ++++++++++++++++++++
 packages/jsts/src/rules/S6855/index.ts       | 23 ++++++++++++++
 packages/jsts/src/rules/index.ts             |  2 ++
 5 files changed, 90 insertions(+)
 create mode 100644 packages/jsts/src/rules/S6855/cb.fixture.jsx
 create mode 100644 packages/jsts/src/rules/S6855/cb.test.ts
 create mode 100644 packages/jsts/src/rules/S6855/decorator.ts
 create mode 100644 packages/jsts/src/rules/S6855/index.ts

diff --git a/packages/jsts/src/rules/S6855/cb.fixture.jsx b/packages/jsts/src/rules/S6855/cb.fixture.jsx
new file mode 100644
index 00000000000..e099a7c9f3b
--- /dev/null
+++ b/packages/jsts/src/rules/S6855/cb.fixture.jsx
@@ -0,0 +1,4 @@
+function MyVideo() {
+  return <video {...props} />; // Noncompliant
+//        ^^^^^
+}
diff --git a/packages/jsts/src/rules/S6855/cb.test.ts b/packages/jsts/src/rules/S6855/cb.test.ts
new file mode 100644
index 00000000000..499064286d9
--- /dev/null
+++ b/packages/jsts/src/rules/S6855/cb.test.ts
@@ -0,0 +1,28 @@
+/*
+ * SonarQube JavaScript Plugin
+ * Copyright (C) 2011-2023 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+import { check } from '../tools';
+import { rule } from './';
+import path from 'path';
+
+const sonarId = path.basename(__dirname);
+
+describe('Rule S6855', () => {
+  check(sonarId, rule, __dirname);
+});
diff --git a/packages/jsts/src/rules/S6855/decorator.ts b/packages/jsts/src/rules/S6855/decorator.ts
new file mode 100644
index 00000000000..19d49bb9096
--- /dev/null
+++ b/packages/jsts/src/rules/S6855/decorator.ts
@@ -0,0 +1,33 @@
+/*
+ * SonarQube JavaScript Plugin
+ * Copyright (C) 2011-2023 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+// https://sonarsource.github.io/rspec/#/rspec/S6855/javascript
+
+import { Rule } from 'eslint';
+import { Node } from 'estree';
+import { TSESTree } from '@typescript-eslint/experimental-utils';
+import { interceptReport } from '../helpers';
+
+export function decorate(rule: Rule.RuleModule): Rule.RuleModule {
+  return interceptReport(rule, (context, descriptor) => {
+    const { node } = descriptor as unknown as { node: TSESTree.JSXOpeningElement };
+    const name = node.name as unknown as Node;
+    context.report({ ...descriptor, node: name });
+  });
+}
diff --git a/packages/jsts/src/rules/S6855/index.ts b/packages/jsts/src/rules/S6855/index.ts
new file mode 100644
index 00000000000..10ffb9291a0
--- /dev/null
+++ b/packages/jsts/src/rules/S6855/index.ts
@@ -0,0 +1,23 @@
+/*
+ * SonarQube JavaScript Plugin
+ * Copyright (C) 2011-2023 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+import { rules as jsxA11yRules } from 'eslint-plugin-jsx-a11y';
+import { decorate } from './decorator';
+
+export const rule = decorate(jsxA11yRules['media-has-caption']);
diff --git a/packages/jsts/src/rules/index.ts b/packages/jsts/src/rules/index.ts
index 7f29ae64d31..d1fa1478654 100644
--- a/packages/jsts/src/rules/index.ts
+++ b/packages/jsts/src/rules/index.ts
@@ -116,6 +116,7 @@ import { rule as S6853 } from './S6853'; // label-has-associated-control
 import { rule as S1439 } from './S1439'; // label-position
 import { rule as S5148 } from './S5148'; // link-with-target-blank
 import { rule as S4622 } from './S4622'; // max-union-size
+import { rule as S6855 } from './S6855'; // media-has-caption
 import { rule as S1994 } from './S1994'; // misplaced-loop-counter
 import { rule as S1082 } from './S1082'; // mouse-events-a11y
 import { rule as S134 } from './S134'; // nested-control-flow
@@ -399,6 +400,7 @@ rules['label-has-associated-control'] = S6853;
 rules['label-position'] = S1439;
 rules['link-with-target-blank'] = S5148;
 rules['max-union-size'] = S4622;
+rules['media-has-caption'] = S6855;
 rules['misplaced-loop-counter'] = S1994;
 rules['mouse-events-a11y'] = S1082;
 rules['nested-control-flow'] = S134;