Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create standard for mandatory and supported IaaS services #587

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

josephineSei
Copy link
Contributor

Copy link
Contributor

@markus-hentsch markus-hentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for minor rephrasing of some things inline.

@markus-hentsch
Copy link
Contributor

Also one thing I only addressed in the review in a shallow manner so far:

I believe we discussed in the community calls previously that we need to make a clearer distinction between OpenStack APIs and the services and be careful about the wording in standards.

The OpenStack services are essentially reference implementations of the APIs. Wherever possible, the SCS should mandate the APIs and their functionalities, not the (backend) services. CSPs should be free to use whatever implementation they like as long as it provides the same API and behavior1. Especially when mandating components, this can be a make or break deal for CSPs.

Footnotes

  1. not that I expect anybody to implement something like a full Nova alternative overnight but from a formal standpoint, the freedom should be there

Copy link
Contributor

@anjastrunk anjastrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two cosmetic issues and one question, which requires clarification.

Copy link
Contributor

@artificial-intelligence artificial-intelligence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the service lists themselves mostly LGTM, but I think some other parts could need some clarification, see the comments.

Thanks for working on this.

@josephineSei
Copy link
Contributor Author

I think we should discuss the supported services list in the IaaS call, as this topic is very important and should not be merged without having overall agreement also for the supported service list.

@josephineSei
Copy link
Contributor Author

We discussed this PR today in the IaaS Call. Especially what "supported service" means.

  • What should users expect from these supported services?
    • that standards refering to overall IaaS also include them (== all services can be enabled to fulfill the standards?)
    • that these services have been tested for integration?
    • that these services are part of the reference implementation? (imho that might be too much)
      • "supported" in the standardization sense can not make statements on the reference implementation
      • meaning of "supported" in standardization may be limited to ensuring that our standards don't conflict with these
        • we don't break them with our standards!
        • renaming "supported" to "recommended"? No: "recommended" has a stronger meaning ...
        • we originally wanted to separate between
          1. (mandatory) you need these APIs to have a scs-compliant cloud
          2. (supported) you may use these APIs, they can be integrated with scs (e.g. work with the scs role standard)
          3. (unsupported) you may use these APIs on your own risk
    • hints and recommendations for the implementation may be added to the implementation notes
  • Generic discussion: We do standardize concrete APIs (the ones that come from OpenStack or K8s or CAPI) to make the
    standards useful -- alternative implementations for services are possible, but a completely different set of technologies
    will unlikely implement the SCS APIs.
  • We need to use the correct terminology "OpenStack Compute API" as opposed to "Nova"
    • Complexity: These APIs are huge, with lots of optional and deprecated pieces
      • Need to work through these, tedious
      • The OpenStack Interop Guideline tests ("OpenStack powered XXX") are a good starting point for this
        • This is a fairly small set, we need to add to this to produce something that is really useful ("this is the motivation for SCS standardization")

In conclusion the PR should focus mor on APIs than OpenStack services. Which has the downside, that we would also need to clarify for each API endpoint, whether this is mandatory, recommended or optional / not needed.

This is a direction which is worth going for, but this will add a load of complexity and might need specific documents for each service API.

Copy link
Contributor

@artificial-intelligence artificial-intelligence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found mostly some typos and some missing replacements of /services/APIs/.

@josephineSei
Copy link
Contributor Author

When I'm correct the only thing missing here for this standard is:
Is the Heat API still in the supported list or not?
@garloff and @fkr you wanted to discuss this, right? Do you have any news about it?

@fkr fkr force-pushed the mandatory-and-supported-IaaS-services branch from c2e3ed2 to 8d5200c Compare June 27, 2024 20:33
josephineSei and others added 2 commits July 1, 2024 09:34
Co-authored-by: Markus Hentsch <[email protected]>
Signed-off-by: josephineSei <[email protected]>
## Introduction

To be SCS-compliant a Cloud Service Provider (CSP) has to fulfill all SCS standards.
Some of those standards are broad and consider all APIs of all services on the IaaS-Layer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please be specific and name at least one example?

Copy link
Contributor

@gtema gtema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S3 with/vs Swift requires a bit more precision in my eyes

| **image** | Glance | Image service |
| **load-balancer** | Octavia | Load-balancer service |
| **network** | Neutron | Networking service |
| **s3** or **object-store** | S3 API object storage | No formal standard exists, many implementations: Swift, RadosGW, minio... |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally dislike "or" here. There are user loads supporting only one of both so having here an OR does not bring much benefit. S3 support in it's own is not standardized enough to have multiple compatibility issues, especially when it comes to the OpenStack Identity related stuff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point. It was a requirement from the beginning to have an object store API as mandatory in each scs-cloud.
CSPs right now use different kinds of object-stores. So we have two options: either make one specific implementation mandatory or we state that CSPs can and must choose an implementation and users have to live with these different options.

Another option would be to make this optionally, but we would have to discuss this again with the IaaS team and Kurt.

What is your opinion on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this in the standardization SIG and following items were raised:

  • S3 was always intended to be mandatory (also for KaaS layer)
  • Swift should be at least "recommended"
    Even though S3 and Swift both implement the same service (object-store) it can be seen as: HDMI output is a must and DisplayPort is recommended

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it should be two separate rows

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change the standard accordingly.
BUT, if S3 is also listed as "object-store" equal to Swift, we have no chance to distinguish between those two services in the tests.
This is a little bit unfortunate, because we will never know for certain, whether the endpoints are from an S3 service or from Swift. So I can change the lines here, but we will not be able to test them!

An option may be to use gaia-x credentials. Which raises the question: Do we have a point, were we state which credentials we require? @garloff ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, in this context, we need a standard for object storage too, similar like for block storage. CSPs need to know the requirements for object store and users need to know, which capabilities an object store has. See, #725

Copy link
Contributor

@anjastrunk anjastrunk Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to @josephineSei: We can not distinguish between two object store APIs in tests. We should define just one as mandatory. Furthermore, setting S3 as mandatory is problematic. As far as I known, S3 API is not in control of OpenStack. There is no official documentation on how S3 for a specific OpenStack release looks like. The latest documentation is from Mitaka. There is no documentation for current release, e.g. Hence, we standardize a moving target IMO.

logger = logging.getLogger(__name__)
mandatory_services = ["compute", "identity", "image", "block-storage",
"network", "load-balancer", "placement"]
object_store_service = ["s3", "object-store"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never seen a single cloud having S3 service/endpoint in the catalog. Typically object-store is also supporting S3 (either it is swift with S3 enabled or it is rgw catalog pointing to swift endpoint).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove it, if there really is no cloud with "s3" as service type. But can we certainly know, that this will never be the case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no tooling existing in the world (known to me) that expects S3 and consumes OpenStack service catalog searching for "s3" service type

@anjastrunk anjastrunk self-requested a review September 2, 2024 08:45
@anjastrunk anjastrunk mentioned this pull request Sep 2, 2024
3 tasks
@anjastrunk
Copy link
Contributor

An other question came to my mind: How does a user know, which API version a certain SCS cloud supports? There is a document on certificates listing all effective standards for a certain scope and version. Standard on mandatory services will be part of a scopes/version, soon. How does the user/reader figure out, which API of which OpenStack service belongs to a given certificate scope and version.

@josephineSei
Copy link
Contributor Author

As discussed in the IaaS meeting, we want to standardize, that the s3 should be mandatory and swift only supported.
I looking into the s3 protocol and the hints for tests from Kurt to adjust the current testing behavior.

The one open question to me (which needs to be tested) is how do we get an endpoint for s3 when we do not have swift? or do we require that swift should be always there - even just as a stump to provide that endpoint in the service catalog?

@josephineSei
Copy link
Contributor Author

josephineSei commented Sep 23, 2024

I was able to test my script and Kurts script against a deployment from Cloud&Heat, which provides a Swift endpoint and also offers S3 behind this endpoint.

$ python3 mandatory-iaas-services.py --os-cloud openstack
The following endpoints are missing: ['block-storage', 'load-balancer']

But it also came up, that there was another description for "block-storage" that was just volume. I need to adjust the test, to allow both options - or do we want to only allow one specific endpoint name:

  1. do we require that all endpoints have to show up in catalog list output?
  2. do we want to maybe only allow one name per service (only block-storage OR volume for the block storage service)?

I would like to answer the first question with yes, because in this way we will always have access to the object storage endpoint, regardless, what service is used.

The second question is more difficult: we may need to adjust the tests to allow more than one name per service - each time a new name comes up. On the other hand: that will have a huge impact on CSPs, so I don't think, we should strictly only allow one name.

@josephineSei
Copy link
Contributor Author

I am installing a minIO server on the same machine my devstack runs on to create a setup, which has an OpenStack and an s3 on the same level but next to it and no Swift enabled. I am looking into minIO to create a user and credentials, which i can use for the test.

@josephineSei
Copy link
Contributor Author

I installed minio in a test environment and started it temporarily:

root@devstack:/opt/stack/devstack# ./minio server /data
MinIO Object Storage Server
Copyright: 2015-2024 MinIO, Inc.
License: GNU AGPLv3 - https://www.gnu.org/licenses/agpl-3.0.html
Version: RELEASE.2024-09-22T00-33-43Z (go1.22.7 linux/amd64)

API: http://192.168.23.161:9000  http://192.168.11.28:9000  http://10.0.2.1:9000  http://192.168.122.1:9000  http://127.0.0.1:9000 
   RootUser: minioadmin 
   RootPass: minioadmin 

WebUI: http://192.168.23.161:46367 http://192.168.11.28:46367 http://10.0.2.1:46367 http://192.168.122.1:46367 http://127.0.0.1:46367          
   RootUser: minioadmin 
   RootPass: minioadmin 

CLI: https://min.io/docs/minio/linux/reference/minio-mc.html#quickstart
   $ mc alias set 'myminio' 'http://192.168.23.161:9000' 'minioadmin' 'minioadmin'

Docs: https://docs.min.io
WARN: Detected default credentials 'minioadmin:minioadmin', we recommend that you change these values with 'MINIO_ROOT_USER' and 'MINIO_ROOT_PASSWORD' environment variables

In another console tab I installed the minio client, logged in as admin, created a new user and gave that users rights to read and write:

stack@devstack:~/devstack$ curl https://dl.min.io/client/mc/release/linux-amd64/mc --create-dirs -o $HOME/minio-binaries/mc
stack@devstack:~/devstack$ mc alias set 'myminio' 'http://192.168.23.161:9000' 'minioadmin' 'minioadmin'
Command 'mc' not found, but can be installed with:
apt install mc
Please ask your administrator.
stack@devstack:~/devstack$ chmod +x $HOME/minio-binaries/mc
stack@devstack:~/devstack$ export PATH=$PATH:$HOME/minio-binaries/
stack@devstack:~/devstack$ mc alias set 'myminio' 'http://192.168.23.161:9000' 'minioadmin' 'minioadmin'
Added `myminio` successfully.
stack@devstack:~/devstack$ mc admin user add myminio newuser newusersecret
Added user `newuser` successfully.
stack@devstack:~/devstack$ mc admin user list myminio
enabled    newuser                                   
stack@devstack:~/devstack$ mc admin policy list myminio
consoleAdmin
diagnostics
readonly
readwrite
writeonly
stack@devstack:~/devstack$ mc admin policy attach myminio readwrite --user newuser
Attached Policies: [readwrite]
To User: newuser

After this I was able to test the script and made adjustments to it until I reached the point, where it succeeded:

stack@devstack:~/devstack$ python3 mandatory-iaas-services3.py --os-cloud mycloud2 --s3-endpoint "http://192.168.23.161:9000" --s3-access newuser --s3-access-secret newusersecret
FAIL: The following endpoints are missing: ['load-balancer']
SUCCESS: S3 exists

When not giving the parameters it will fail:

stack@devstack:~/devstack$ python3 mandatory-iaas-services3.py --os-cloud mycloud2
FAIL: The following endpoints are missing: ['load-balancer', 'object-store']
FAIL: No object store endpoint found. No testing for the s3 service possible. Details: public endpoint for object-store service not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Define a list of mandatory and of optional (supported) SCS OpenStack services
7 participants