Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playwright] expose IConfiguration of specflow.actions.json #62

Open
304NotModified opened this issue Nov 25, 2021 · 3 comments
Open

[Playwright] expose IConfiguration of specflow.actions.json #62

304NotModified opened this issue Nov 25, 2021 · 3 comments

Comments

@304NotModified
Copy link

We like to add some additional properties to specflow.actions.json

But currently it seems we have to (re-read) in our own code specflow.actions.json then.

Please expose the IConfiguration - or make it possible to inject.

@DomZZ
Copy link

DomZZ commented Dec 14, 2021

I drop my own browser implementation to use yours (to standardize development and get the opportunity to have new features from you and the OSS community). But when you are in rush and really need a feature, you need to have the possiblity to quickly integrate it without waiting that specflow or someone else implement it.

@TechWatching
Copy link

A linked topic would be to be able to add secrets in the configuration provided by the secrets.json file or by a KeyVault.

@SabotageAndi
Copy link
Contributor

We changed SpecFlow.Actions.Configuration to use the standard ConfigurationBuilder. You can access it via ISpecFlowActionsConfiguration.
There is no schema on the specflow.actions.json so you can add your properties where you like.

Is this enough @304NotModified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants