Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved file-open operation in BinaryRecordingSegment out of constructor #3296

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Moved file-open operation in BinaryRecordingSegment out of constructor #3296

wants to merge 2 commits into from

Commits on Aug 8, 2024

  1. Move file open from BinaryRecordingSegment constructor to get_traces(… 

    …) method, and uses with statment so that the file will close after it's no longer needed
    chris committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    1414e62 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Move return within open statement block

    chris committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    18f6dc0 View commit details
    Browse the repository at this point in the history