Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving serialization error messages #298

Open
Machine-Maker opened this issue Jun 13, 2022 · 0 comments
Open

Improving serialization error messages #298

Machine-Maker opened this issue Jun 13, 2022 · 0 comments

Comments

@Machine-Maker
Copy link
Contributor

In a bunch of places, I think exceptions should include 3 things. The input value (string for deserialization, object for serialization), the type (expected type for deserialization, initial type for deserialization), and the exact NodePath to that point.

And this should be consistent everywhere. For example the BooleanSerializer has 2 of those, but doesn't give the exact input value, just that it couldn't convert a String into a boolean.

I think there are some special cases like Maps where some more indepth stuff should be done. For example the message should say if it was a key for value that failed. I did some of this stuff for Paper making my own MapSerializer (see here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants