Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing stub executable #1657

Closed
SultanaJon opened this issue Sep 4, 2020 · 2 comments
Closed

Signing stub executable #1657

SultanaJon opened this issue Sep 4, 2020 · 2 comments

Comments

@SultanaJon
Copy link

SultanaJon commented Sep 4, 2020

Squirrel version(s)
v2.0.0

Description
I am signing an application and then creating a release with Squirrel. When I install the application, the stub executable is not signed but the one within the ‘app-{version}’ directory is signed. I see that Slack’s stub executable is signed and I want to replicate that behavior. Can you explain how to achieve this?

Steps to recreate

<Target Name="AfterBuild" Condition=" '$(Configuration)' == 'Release'">
    <GetAssemblyIdentity AssemblyFiles="$(TargetPath)">
      <Output TaskParameter="Assemblies" ItemName="myAssemblyInfo" />
    </GetAssemblyIdentity>
    <Exec Command="signtool sign /tr http://timestamp.digicert.com /td sha256 /fd sha256 /a $(OutDir)myApp.exe" />
    <Exec Command="nuget pack myApp.nuspec -Version $([System.Version]::Parse(%(myAssemblyInfo.Version)).ToString(3)) -Properties Configuration=Release -OutputDirectory $(OutDir) -BasePath $(OutDir)" />
    <Exec Command="Squirrel.exe --releasify $(OutDir)myAppd.$([System.Version]::Parse(%(myAssemblyInfo.Version)).ToString(3)).nupkg" />
  </Target>

Expected behavior
The stub executable should be signed.

Actual behavior
The stub executable is not signed.

Additional Information
I have reviewed PR #868 and searched the open and closed issues for my problem.

@owns
Copy link

owns commented Sep 5, 2020

Hello @SultanaJon. Please see the docs on application signing.
My absolute favorite part of open source is checking "under-the-hood". You can see in the source, it creates the stub(s), then signs all files.
I am not a moderator, so if you could close the issue if this resolves your problem, I'd appropriate it.

@SultanaJon
Copy link
Author

I changed my releasify command to sign all files instead of just the app executable. This fixed the issue described above. Thanks @owns!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants