Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.1: meson fails in sphinx-build command #368

Closed
kloczek opened this issue Aug 1, 2022 · 7 comments
Closed

1.4.1: meson fails in sphinx-build command #368

kloczek opened this issue Aug 1, 2022 · 7 comments
Assignees
Milestone

Comments

@kloczek
Copy link

kloczek commented Aug 1, 2022

Meson fails with:

Program sphinx-build found: YES (/usr/bin/sphinx-build)

docs/meson.build:11:2: ERROR: Command "/usr/bin/sphinx-build -b man /home/tkloczko/rpmbuild/BUILD/srain-1.4.1/docs /home/tkloczko/rpmbuild/BUILD/srain-1.4.1/x86_64-redhat-linux-gnu/docs/man" failed with status 2.

A full log can be found at /home/tkloczko/rpmbuild/BUILD/srain-1.4.1/x86_64-redhat-linux-gnu/meson-logs/meson-log.txt

In log file it is possible to find:

Running command: /usr/bin/sphinx-build -b man /home/tkloczko/rpmbuild/BUILD/srain-1.4.1/docs /home/tkloczko/rpmbuild/BUILD/srain-1.4.1/x86_64-redhat-linux-gnu/docs/man
--- stdout ---
Running Sphinx v5.1.1

--- stderr ---

Extension error:
Could not import extension sphinxnotes.strike (exception: No module named 'sphinxnotes')
  • which one exacly module it is? (pypi cannot find sphinxnotes)
  • Looks like in meson.build is missing line like import('python').find_installation('python3', modules : ['sphinx', 'sphinxnotes'])
@SilverRainZ
Copy link
Member

which one exactly module it is? (PyPI cannot find sphinxnotes)

The required modules are listed in docs/requirements.txt, they are:

sphinx-book-theme
ablog
sphinxnotes-strike
sphinxnotes-mock
sphinx_sitemap
sphinxcontrib.gtagjs
sphinxext.opengraph

Looks like in meson.build is missing line like import('python').find_installation('python3', modules : ['sphinx', 'sphinxnotes'])

Yes, hardcoded python command is not good. would you like to file a pull request?

@kloczek
Copy link
Author

kloczek commented Aug 1, 2022

Yes, hardcoded python command is not good. would you like to file a pull request?

Why not 😄 .. however it would be good to know where I can find sphinxnotes to be able test that before create PR 😋

@kloczek
Copy link
Author

kloczek commented Aug 1, 2022

BTW .. is it really necessary to use all those sphinx extensions to create main page? 🤔

@SilverRainZ
Copy link
Member

Why not smile .. however it would be good to know where I can find sphinxnotes to be able test that before create PR yum

pip install sphinxnotes-strike sphinxnotes-mock

@SilverRainZ
Copy link
Member

BTW .. is it really necessary to use all those sphinx extensions to create main page? thinking

In fact it is not needed and we can consider not introducing these dependencies when building the manpage.

@SilverRainZ SilverRainZ self-assigned this Aug 2, 2022
@SilverRainZ
Copy link
Member

which one exacly module it is? (pypi cannot find sphinxnotes)

Does your problem solve after installing the above package?

Looks like in meson.build is missing line like import('python').find_installation('python3', modules : ['sphinx', 'sphinxnotes'])

I remove the dependency in #370, can you please have a try?

@SilverRainZ
Copy link
Member

Since Srain documentation does not longer require any extra python package, close this issue.

@SilverRainZ SilverRainZ added this to the 1.5 milestone Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants