Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with RC.6 #52

Closed
dagstuan opened this issue Sep 1, 2016 · 2 comments
Closed

Incompatible with RC.6 #52

dagstuan opened this issue Sep 1, 2016 · 2 comments

Comments

@dagstuan
Copy link

dagstuan commented Sep 1, 2016

The package is currently incompatible with RC.6 of Angular 2 due to the removal of ComponentResolver and the renaming of DomSanitizationService to DomSanitizer
@Stabzs Stabzs closed this as completed in eebbd01 Sep 2, 2016
@klaascuvelier
Copy link

@Stabzs thanks for the quick fix.
Seems to work fine now, but the build fails

@Stabzs
Copy link
Owner

Stabzs commented Sep 2, 2016

Yes there are issues getting the upgraded tests and test structure to build on CI, although they run correctly locally and coverage remains at 100%. I felt it was more important to deliver RC6 functionality than to hold off working on CI. Corrections to the test build will be added soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@klaascuvelier @dagstuan @Stabzs