Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments have labels that are redundant when existing secrets are provided. #393

Closed
bmarick opened this issue Feb 7, 2024 · 1 comment
Labels
enhancement New feature or request Helm

Comments

@bmarick
Copy link
Contributor

bmarick commented Feb 7, 2024

When providing an existing Auth or DataStore Key secret it generates a checksum of a file that is never needed.
Sense the file is not used, the checksum becomes a static value.
Additionally, this checksum is calculated multiple times.
This results in larger output templates and slower helm chart builds.
My suggestion is to remove them.

@cognifloyd
Copy link
Member

I believe #391 and #392 implement this. If anything else is required, we can reopen or file a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Helm
Projects
None yet
Development

No branches or pull requests

2 participants