Kubeflow: define upgrade path to kf 1.4

[chuckbelisle]

Epic: #1203

Placeholder ticket to start the kubeflow 1.4 planning and task creation

[bryanpaget]

Kubeflow v1.4.0 Release Notes

This is a checklist of all the items we need to check before the upgrade can proceed.

Just take note of whether we need to do any work to upgrade or if we can simply rebase.

Web apps:

(Assigned to @bryanpaget)

• Migrate to Angular 12 from 8: Update CRUD web apps from Angular 8 to Angular 12 kubeflow/kubeflow#6004

✅ We will have to upgrade to Angular 12 since everything else depends on it.

Internationalization progress

(Assigned to @wg102)

• Internationalization to web apps CRUD web apps: i18n kubeflow/kubeflow#5880 @wg102, @Jose-Matsuda
  ✅ This one should be fine since it was to upstream our code
• Use Angular's i18n solution fix(web-apps): Use Angular's i18n proposed implementation kubeflow/kubeflow#6065
  ⚠️ This change needs to be discussed or further investigated. TL/DR: They removed the localization the way we had decided to do it and use @angular/localize": "^12.0.5" instead. Need to weight pros/cons of going with their decision before going forward with a choice.

Central Dashboard:

(Assigned to @bryanpaget)

Compare to our code, we have to keep our branding and links specific to AAW/DAaaS.

• Namespaced menu items Interact with the namespace selector kubeflow/kubeflow#5995
  ✅ Looks okay, might not break anything. May have to pay attention to internationalization.
• Make it possible to add Namespaced menu items Make it possible to add Namespaced menu items kubeflow/kubeflow#5871
  ✅ Looks okay, might not break anything. May have to pay attention to internationalization.
• Scrollable side-bar Make menu bar scrollable again kubeflow/kubeflow#5964
  ✅ Looks okay, just some CSS, might not break anything.
• Add support for Models web app [CentralDashboard] Add entry for Models web app kubeflow/kubeflow#6085
  ✅ Looks okay, just some CSS. May have to pay attention to internationalization.

Jupyter web app

(Assigned to @wg102)

This is where we have the most customization and we even use a different backend.

• Jupyter web app fix for autoscaling GPU nodegroups jwa(front): Don't disable vendors with no GPUs kubeflow/kubeflow#6171
  ⚠️ Not sure, I think we will take the change, but might disable it too. Ask how we want to handle GPU
• Fix limits calculation when limitFactor is none in Jupyter web app fix(jwa): Fix limits calculation when limitFactor is none kubeflow/kubeflow#6058
  ⚠️ I am expecting this to run into conflict with some of our own customization
• Make jupyter-web-app parse workspace volume MountPath [fix]: Make jupyter-web-app parse workspace volume MountPath kubeflow/kubeflow#5952
  ✅ Seems to have already been included in 1.3.1
• JWA: Don't override assets with logos ConfigMap JWA: Don't override assets with logos ConfigMap kubeflow/kubeflow#5942
  ⚠️ Very important, might already have been corrected in our version. Therefore might conflict
• Add fonts as assets to service feat(jupyter): add fonts as assets to service kubeflow/kubeflow#5691 @saffaalvi @wg102
  ✅ Was our contribution
• The number of gpu must be set as string FIX The number of gpu must be set as string in Kubernetes/Openshift kubeflow/kubeflow#5891
  ✅ Don't expect trouble

Notebooks

(Assigned to @bryanpaget)

• Remove virtualservice timeout to prevent websocket disconnect Remove virtualservice timeout to prevent websocket disconnect kubeflow/kubeflow#6126
  ✅ Looks okay, might not break anything.
• Correct missing predicates in controller watches Correct missing predicates in controller watches. Fixes #5326 kubeflow/kubeflow#5873
  ⚠️Not sure! A lot of Go code changes.
• Improve the README of the example Notebook servers Improve README for example-notebook-servers kubeflow/kubeflow#6165
  ✅ Only the README changed!

TensorBoards

(Assigned to @wg102)

• tensorboard-controller: fix binding issue tensorboard-controller: fix binding issue kubeflow/kubeflow#5925
  ✅ Since we do not currently use TensorBoard it should have no impact

PodDefaults

(Assigned to @bryanpaget)

• Bump Golang version for PodDefaults, TensorBoard Controller and KFAM Bump Golang version in PodDefaults, TensorBoard Controller and KFAM to 1.17 kubeflow/kubeflow#6180
  ⚠️We'll need to update Go to 1.17.
  ⚠️Many new packages required from Github.
• Use namespace from Admission Review in PodDefaults fix(admission-webhook): attach namespace to pod request if pod does not have it kubeflow/kubeflow#6052
  ✅ Should be okay.
• Add support for ServiceAccountName and AutomountServiceAccountName to PodDefaults
• Add support for ServiceAccountName and AutomountServiceAccountName to admission-webhook kubeflow/kubeflow#5939
  ✅ Should be okay.

Other improvements

(Assigned to @wg102)

• Add kustomize tests in CI/CD CI/CD: add kustomize build tests kubeflow/kubeflow#5919
  ⚠️ This is about PY, if we want the equivalent, will have to code it.
• Format checks for the Volumes web app Add CI format checks for the Volumes web app kubeflow/kubeflow#5820
  ✅ Formatting
• Make i18n work with prefixes WA: Use relative paths for fetching translation files kubeflow/kubeflow#6034
  ⚠️ We will most likely need to rewrite some of this commit.
• Allow user to add/delete labels to user namespace using ConfigMap Allow user to add/delete labels to user namespace using ConfigMap. Fix #5712 kubeflow/kubeflow#5761
  ⚠️ Some of their customizations will overlap with ours. In particular kustomization.yaml and namespace-labels.yaml.

[bryanpaget]

According to the Kubeflow 1.4.1 release notes, https://www.kubeflow.org/docs/releases/kubeflow-1.4/, we'll need to use Kubeflow Pipelines 1.7.0 with Kubeflow 1.4.1.

[wg102]

TODO: Once we go throught the kubeflow repo changes, we will need to compare the manifest.

[wg102]

The details have been added to the epic