Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move argocd-vault-plugin files to gitlab argocd definition #1916

Open
mathis-marcotte opened this issue Dec 12, 2023 · 0 comments
Open

Move argocd-vault-plugin files to gitlab argocd definition #1916

mathis-marcotte opened this issue Dec 12, 2023 · 0 comments
Assignees

Comments

@mathis-marcotte
Copy link
Contributor

follow up of #1884
The reason I went with the solution with files in the manifests repo was because I was more familiar with that repo, and I don't have rights to run the tf apply command in the gitlab repo. So it was a lot more easy for testing for me. In the future, I think we should add these components where our ArgoCD instance is initially defined in gitlab. This would keep our argocd install all in one place. This would also mirror how CNS did the install. Plus, I have seen some issues in my testing where the argo instance would get re-created, and it would then ignore the deployment override defined in the manfest repo and therefore wouldn't have the plugin installed. So having everything in one place would solve this potential issue

@mathis-marcotte mathis-marcotte self-assigned this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant