Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement join(self, join: str) for PaymentsCallBuilder #321

Closed
KStasi opened this issue May 26, 2020 · 1 comment
Closed

Implement join(self, join: str) for PaymentsCallBuilder #321

KStasi opened this issue May 26, 2020 · 1 comment
Assignees
Labels

Comments

@KStasi
Copy link

KStasi commented May 26, 2020

Is your feature request related to a problem? Please describe.
Native Horizon API allows query option ?join for payments https://www.stellar.org/developers/horizon/reference/endpoints/payments-for-account.html
This is quite handy because it reduces the number of requests needed to get all information about transactions with payments without fetching unrelated operations.

Describe the solution you'd like
Add method for PaymentsCallBuilder similar to

def join(self, join: str) -> "OperationsCallBuilder":
"""join represents `join` param in queries, currently only supports `transactions`
:param join: join represents `join` param in queries, currently only supports `transactions`
:return: current OperationsCallBuilder instance
"""
self._add_query_param("join", join)
return self

@overcat
Copy link
Member

overcat commented May 27, 2020

Thanks for your response, released in 2.5.1.

@overcat overcat closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants