Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SEP-10, adds a 5 minute grace period to read_challenge_transaction min_time constraint #526

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

overcat
Copy link
Member

@overcat overcat commented Sep 18, 2021

@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #526 (93d46ed) into v4 (8d40fbf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4     #526   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files         129      129           
  Lines        8987     9019   +32     
=======================================
+ Hits         8901     8933   +32     
  Misses         86       86           
Flag Coverage Δ
unittests 99.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stellar_sdk/sep/stellar_web_authentication.py 94.76% <100.00%> (+0.02%) ⬆️
tests/sep/test_stellar_web_authentication.py 100.00% <100.00%> (ø)

@overcat overcat merged commit fc76981 into v4 Sep 18, 2021
@overcat overcat deleted the sep-10-add-grace-period-to-challenge-reader branch September 18, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant