Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling mixins via config (e.x. GenerationShapeConfigMixin) #26

Open
davidromrell opened this issue Apr 21, 2024 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@davidromrell
Copy link

because it alters noise gen in a way that overrides other optimizations any ideas or suggestions

@Steveplays28
Copy link
Owner

Steveplays28 commented Apr 21, 2024

Hi davidromrell, thanks for checking out Noisium.
What do you mean by it overriding other optimisations?
Do you have any examples?

@Steveplays28 Steveplays28 added the question Further information is requested label Apr 21, 2024
@Steveplays28 Steveplays28 changed the title Lost performance from GenerationShapeConfigMixin Lost performance from GenerationShapeConfigMixin Apr 21, 2024
@Steveplays28 Steveplays28 changed the title Lost performance from GenerationShapeConfigMixin Lost performance from GenerationShapeConfigMixin Apr 21, 2024
@davidromrell
Copy link
Author

davidromrell commented Apr 21, 2024

Although the current method should be saved or backed up somewhere because it is great at causing ideas, and I am sure others might use as well. The way it goes into specific block placements, could cause issues with mod conflict. I noticed the performance of your mod although is good it undoes optimizations from some world generation data packs a simple test framework would be to test is https://modrinth.com/datapack/aesthetic-and-performant/version/1.2+mod and FastRandom, , and benchmarking your mod. Let me know if you can change it, if not let me know so I can make a mod version for compat.

@Steveplays28
Copy link
Owner

Steveplays28 commented Apr 23, 2024

I could add an option to disable the mixin via config and/or when your mod is loaded.

@davidromrell
Copy link
Author

davidromrell commented Apr 24, 2024

When my mod or FastRandom is loaded and if a config option is added should work. Although you will likely have to state that with any worldgen mods/packs/etc that alter specific block placements it might have a slight performance increase removed.

@Steveplays28
Copy link
Owner

Alright, will add that sometime.
Thanks for looking into compatibility.

@Steveplays28 Steveplays28 changed the title Lost performance from GenerationShapeConfigMixin Allow disabling mixins via config (e.x. GenerationShapeConfigMixin) Apr 27, 2024
@Steveplays28 Steveplays28 added enhancement New feature or request and removed question Further information is requested labels Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants