-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling mixins via config (e.x. GenerationShapeConfigMixin
)
#26
Comments
Hi davidromrell, thanks for checking out Noisium. |
GenerationShapeConfigMixin
GenerationShapeConfigMixin
GenerationShapeConfigMixin
Although the current method should be saved or backed up somewhere because it is great at causing ideas, and I am sure others might use as well. The way it goes into specific block placements, could cause issues with mod conflict. I noticed the performance of your mod although is good it undoes optimizations from some world generation data packs a simple test framework would be to test is https://modrinth.com/datapack/aesthetic-and-performant/version/1.2+mod and FastRandom, , and benchmarking your mod. Let me know if you can change it, if not let me know so I can make a mod version for compat. |
I could add an option to disable the mixin via config and/or when your mod is loaded. |
When my mod or FastRandom is loaded and if a config option is added should work. Although you will likely have to state that with any worldgen mods/packs/etc that alter specific block placements it might have a slight performance increase removed. |
Alright, will add that sometime. |
GenerationShapeConfigMixin
GenerationShapeConfigMixin
)
because it alters noise gen in a way that overrides other optimizations any ideas or suggestions
The text was updated successfully, but these errors were encountered: