Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting is broken when using frontmatter (after upgrading to VS Code 1.92) #94

Closed
eminos opened this issue Aug 2, 2024 · 4 comments

Comments

@eminos
Copy link

eminos commented Aug 2, 2024

Describe the bug
Seems the syntax highlighting is somewhat broken after upgrading to VS Code 1.92.
Having a frontmatter on the antlers file breaks the syntax highlighting. Or to be more precise, having more then one line

This works:
image

This breaks it:
image

Impacted Products
Antlers Toolbox for VS Code

Versions and Other Plugins/Extensions
VS Code 1.92.0
Antlers Toolbox v2.6.19

@eminos
Copy link
Author

eminos commented Aug 10, 2024

Removed a few unrelated extensions, restarted VS Code, and now it's all back to normal...
Seems to have updated VS Code to 1.92.1 as well.
I have non idea what actually solved it.
It has probably nothing to do with this extension 🙂

@eminos eminos closed this as completed Aug 10, 2024
@JohnathonKoster
Copy link
Contributor

Interesting! Thanks for updating the issue, though 🙏

@RedCMD
Copy link

RedCMD commented Aug 20, 2024

caused by microsoft/vscode#219833

you will need to update your frontMatter integration to something like microsoft/vscode-markdown-tm-grammar#162

"frontMatter": {
"begin": "\\A-{3}\\s*$",
"contentName": "meta.embedded.block.frontmatter",
"patterns": [
{
"include": "source.yaml"
}
],
"end": "(^|\\G)-{3}|\\.{3}\\s*$"
},

before VSCode re-adds the new YAML grammar again

related: microsoft/vscode#224862

@JohnathonKoster
Copy link
Contributor

Thank you for the extra info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants