Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error log when a client tries to update their friendlist without being authenticated #11

Open
jmderuty opened this issue Sep 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jmderuty
Copy link
Member

jmderuty commented Sep 27, 2024

If disconnecting concurrently to updating the friendlist, an error log is produced on the server, because updateFriendList is a Fire&forget API which cannot send back exceptions, which triggers the "unhandled exception" logging system.

{
  "message": "An unhandled async exception occurred : 'System.AggregateException: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. (NotAuthenticated)\n ---> Stormancer.ClientException: NotAuthenticated\n   at Stormancer.Server.Plugins.Friends.FriendsController.UpdateFriendList(Packet`1 packet) in /_/src/Stormancer.Plugins/Friends/Stormancer.Server.Plugins.Friends/FriendsController.cs:line 286\n   at Stormancer.Server.Plugins.API.ControllerFactory`1.ExecuteRouteAction(ApiCallContext`1 ctx, Func`4 action)\n   at Stormancer.Server.Plugins.API.ControllerFactory`1.ExecuteRouteAction(ApiCallContext`1 ctx, Func`4 action)\n   at Stormancer.Server.Plugins.API.ControllerFactory`1.ExecuteRouteAction(ApiCallContext`1 ctx, Func`4 action)\n   --- End of inner exception stack trace ---'",
  "data": {
    "content": {
      "Type": "AggregateException",
      "Message": "A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. (NotAuthenticated)",
      "Frames": [],
      "InnerExceptions": [
        {
          "Type": "ClientException",
          "Message": "NotAuthenticated",
          "Frames": [ "   at Stormancer.Server.Plugins.Friends.FriendsController.UpdateFriendList(Packet`1 packet) in /_/src/Stormancer.Plugins/Friends/Stormancer.Server.Plugins.Friends/FriendsController.cs:line 286", "   at Stormancer.Server.Plugins.API.ControllerFactory`1.ExecuteRouteAction(ApiCallContext`1 ctx, Func`4 action)", "   at Stormancer.Server.Plugins.API.ControllerFactory`1.ExecuteRouteAction(ApiCallContext`1 ctx, Func`4 action)", "   at Stormancer.Server.Plugins.API.ControllerFactory`1.ExecuteRouteAction(ApiCallContext`1 ctx, Func`4 action)" ],
          "InnerExceptions": []
        }
      ]
    },
    "app": "/darktales/live-1-0/2874dc89-a311-4567-9dbc-fb6d8e76cb12/15?"
  }
}
@jmderuty jmderuty self-assigned this Sep 28, 2024
@jmderuty jmderuty added the bug Something isn't working label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant