Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can't remove aliases, only add new. #114

Open
LeMyst opened this issue Jan 26, 2020 · 1 comment
Open

You can't remove aliases, only add new. #114

LeMyst opened this issue Jan 26, 2020 · 1 comment

Comments

@LeMyst
Copy link
Contributor

LeMyst commented Jan 26, 2020

The set_aliases function take a list of strings as parameters, check if the alias already exist or not and add the missings one to the list.
At the moment, we can't (afaik) remove alias on an item.

I propose two options (breaking changes) :

  • Update the set_aliases function to test if aliases parameters is a string or list :
    • If a string, add the alias to the aliases (if missing)
    • If a list, replace all the current aliases by the new list
  • Update the set_aliases function and add a new add_alias :
    • set_aliases take a list of string as parameter and replace the current aliases by the new ones
    • add_alias take a string as parameter and add it to the current list of aliases

I don't know which one is better, but atm we don't have any add_ or rem_ functions, only get_ and set_.

This issue is open for comments. 😉

@LeMyst
Copy link
Contributor Author

LeMyst commented Jul 23, 2020

Another issues with the aliases:

  • You can pass a string in set_aliases() and wikidataintegrator parse this into multiple aliases
  • The fastrun seem to don't detect changes when you try to remove multiple aliases but not all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant