Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering issues with links inside headings #267

Closed
jhass opened this issue Apr 19, 2020 · 6 comments
Closed

Rendering issues with links inside headings #267

jhass opened this issue Apr 19, 2020 · 6 comments

Comments

@jhass
Copy link

jhass commented Apr 19, 2020

Links inside headings generate all kinds of suboptimal renderings.

For example:

<h1><a href="http://example.org">Test</a></h1>
<h1>Longer: <a href="http://example.org">Test</a></h1>

renders both headings on the same line without any space.

<h1>Longer: <a href="http://example.org">Test for the link text in here</a></h1>

breaks to a new line before the anchor tag whereas browser choose to break on a word boundary within the anchor.

@Sub6Resources
Copy link
Owner

Which flutter_html version are you using?

@jhass
Copy link
Author

jhass commented Apr 19, 2020

The latest 1.0 prerelease

@Sub6Resources
Copy link
Owner

Okay, thank you. I'll look into it.

@vptcnt
Copy link

vptcnt commented May 14, 2020

Hello, same here.
Long link breaks to a new line before the anchor tag

Example:

L&rsquo; <a href="https://www.facebook.com/YYYYYYY/posts/XXXXXXXXXXXXXX" target="_blank" rel="noopener noreferrer">Alliance des organisations internationales des États-Unis </a> honore...

renders

L'
Alliance des organisations internationales des États-Unis
honore

With a short link:

L&rsquo; <a href="https://www.facebook.com/YYYYYYY/posts/XXXXXXXXXXXXXX" target="_blank" rel="noopener noreferrer">Alliance des organisations</a> honore...

renders

L'Alliance des organisations honore...

Thanks for your feedback.

@erickok
Copy link
Collaborator

erickok commented Feb 8, 2021

Fixed in #499.

@erickok erickok closed this as completed Feb 8, 2021
@erickok
Copy link
Collaborator

erickok commented Feb 8, 2021

Mind you, this is not released yet - so use the master branch if you must

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants