Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-compliant zip download #225

Closed
rhoot opened this issue May 16, 2021 · 1 comment · Fixed by #243 or #242
Closed

Non-compliant zip download #225

rhoot opened this issue May 16, 2021 · 1 comment · Fixed by #243 or #242

Comments

@rhoot
Copy link

rhoot commented May 16, 2021

The zip file provided for the manual install of 4.1.2 on Nexus Mods doesn't follow the zip standard and as such can't be used with all zip applications. In particular, the file can't be properly extracted on Linux (I tried both GNOME Archive Manager and command line unzip). Instead I ended up having to use a Windows VM to properly extract it.

The problem is the paths inside the zip file contain backslashes. Per the zip standard:

4.4.17.1 The name of the file, with optional relative path. The path stored MUST NOT contain a drive or device letter, or a leading slash. All slashes MUST be forward slashes / as opposed to backwards slashes \ for compatibility with Amiga and UNIX file systems etc. If input came from standard input, there is no file name field.

It appears some zip tools in Windows fails to follow this due to an earlier bug in .NET Framework's zip implementation.

I don't know what tool was used to create that zip file, but:

  • The 4.0.2.6 download for Subnautica did not have that problem.
  • The 4.0.3.4 download for Below Zero also did not have that problem.
  • The 4.1.2 download for Below Zero does.

If you could switch back to an archiver that produces proper zip files for future versions, it would save myself (and probably like 2 other people) a lot of trouble. 😄

@MrPurple6411
Copy link
Member

I recently automated the zip file creation directly in the build process to make our lives easier to build it and get updates out as easily as possible... Going back to manual would be quite irritating but I will look to see if there is an alternative I can use to the PowerShell compress system I just setup. no promises

This was linked to pull requests Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants