From 44c62b873d98d363ed6394544185caf516b54cf7 Mon Sep 17 00:00:00 2001 From: Dmitrii Duzhinskii Date: Thu, 19 Oct 2023 21:49:12 +0300 Subject: [PATCH] Don't catch exceptions in service methods It makes handling exceptions in interceptors hard. On the other hand, if there is no interceptor catching StatusRuntimeException the response status is UNKNOWN. --- .../server/OverriddenServiceMethodGenerator.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/generator/src/main/java/org/sudu/protogen/generator/server/OverriddenServiceMethodGenerator.java b/generator/src/main/java/org/sudu/protogen/generator/server/OverriddenServiceMethodGenerator.java index 1a9ccb7..7d48e01 100644 --- a/generator/src/main/java/org/sudu/protogen/generator/server/OverriddenServiceMethodGenerator.java +++ b/generator/src/main/java/org/sudu/protogen/generator/server/OverriddenServiceMethodGenerator.java @@ -61,11 +61,11 @@ private TypeModel responseTypeModel() { @NotNull private CodeBlock generateBody() { return CodeBlock.of(""" - try { - $>$L$< - } catch (Throwable $$t) { responseObserver.onError($$t); } - finally { responseObserver.onCompleted(); } - """, generateAbstractMethodCall()); + $L + responseObserver.onCompleted(); + """, + generateAbstractMethodCall() + ); } private CodeBlock generateAbstractMethodCall() {