This repository has been archived by the owner on Feb 5, 2021. It is now read-only.
Correctly remove the dynamic replicaset from the pod_name #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendrucker
reviewed
Dec 4, 2018
|
|
||
| def to_hash(pod_template_hash) | ||
| # Convert the pod_template_hash to an alphanumeric string using the same | ||
| # logic Kubernetes uses at https://github.com/kubernetes/apimachinery/blob/master/pkg/util/rand/rand.go#L119 |
There was a problem hiding this comment.
You should use a permanent link here in case this module moves:
| @@ -28,6 +28,31 @@ def is_number?(string) | |||
| true if Float(string) rescue false | |||
| end | |||
|
|
|||
| def strip_dynamic_bits(k8s_metadata) | |||
There was a problem hiding this comment.
I'd recommend def sanitize_pod_name
|
Thanks for the suggestions, I've updated the PR with the requested changes. |
|
Hey @frankreno, this implements the suggestion I made in #78 (comment). Should be good to merge when you have a chance! |
|
@bendrucker thanks for reviewing! @nmohoric - Thanks for the PR! I am going to merge, but want to give a couple of more days for the pending PRs I just reviewed as well as submit a PR to upgrade the FluentD Output Plugin. I will add a comment when I cut a new release with the changes, next week sometime. |
|
v2.1.0 is out with this change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #78