Skip to content
This repository has been archived by the owner on Feb 5, 2021. It is now read-only.

Polish "reduce metadata" feature #108

Merged
merged 5 commits into from
Jan 25, 2019

Conversation

bendrucker
Copy link
Contributor

We noticed our log volume has been increasing pretty steadily as we move apps onto Kubernetes while the line count has remained unchanged. We attributed this to the additional k8s metadata in each line. While we include some bits of data in the _source* fields, we do want to keep some info around to ensure we can identify every pod from its logs. Was super pleased to discover that this was added a month ago!

I noticed that the docs needed some love and that a property was missing. Changes:

  • Includes namespace_name as described in the original PR. Without a namespace, a pod cannot be uniquely identified.
  • Adds full documentation around which properties are excluded/included and why
  • Avoids focusing on the annotation part of the feature (mentions the global env var and emphasizes behavior over configuration).
  • Fixes broken TOC link
  • Updates to bundler@2 (unrelated, but required to run tests)

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankreno frankreno merged commit d2c3259 into SumoLogic:master Jan 25, 2019
@frankreno
Copy link
Contributor

@bendrucker - give me a week to see if we get anything else coming in or if i have time to tackle some other enhancements before i cut a new image.

@bendrucker
Copy link
Contributor Author

Sounds good. We're not desperate for the namespace_name, just seemed worth fixing in the midst of docs tweaking.

@bendrucker bendrucker deleted the metadata-reduce-namespace branch January 28, 2019 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants