Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JustEnoughResources integration #24

Open
LemADEC opened this issue Aug 11, 2018 · 6 comments
Open

JustEnoughResources integration #24

LemADEC opened this issue Aug 11, 2018 · 6 comments
Labels
enhancement New feature or request

Comments

@LemADEC
Copy link

LemADEC commented Aug 11, 2018

As of dungeonmobs-5.4.2-MC1.12.2, entity drops are missing in JustEnoughResources-1.12.2-0.8.9.48.
To my understanding, integration shall be added through their API.

@BlackJar72
Copy link
Collaborator

I never realized it did anything to do with mob drops -- and can't see why it would. I don't know if this will ever be gotten too (I'm moving away from modding, I may join GnomeWorks in the "retired" modders club not in the not to distant future, or slow down a lot either way). I'm not sure why this would be useful, actually -- the drops are just vanilla items, and they aren't recipes so you need to know them for making things.

My first reaction is "will not be worked on," but I'll leave it for consideration.

@LemADEC
Copy link
Author

LemADEC commented Aug 11, 2018

JER shows the mob drops in JEI. It's not for recipe making, it's just to help understand which mobs drop what.

@BlackJar72 BlackJar72 added the enhancement New feature or request label Aug 11, 2018
@BlackJar72
Copy link
Collaborator

OK, no promises and not right a away -- I'm basically slowing down to a bit of dabbling as an alternative to just giving modding up -- but I'll consider it part of the possible features to add list.

(And can't speak for what @Sunconure11 might or might not do.)

@Sunconure11
Copy link
Owner

At the moment, my ISP is being a PITA

@khift363
Copy link

khift363 commented Dec 4, 2018

I believe this is actually related to issue #33 that I just posted. As I understand it, Just Enough Resources detects mob drops by scanning registered loot tables, and the reason JER cannot see the Dungeon Mobs Reborn loot tables is because they're unregistered. Registering the loot tables should, if my knowledge of the situation is correct, solve both issues.

@BlackJar72
Copy link
Collaborator

Modern loot tables for (most) mob drops has actually been on the TODO list for a while -- just haven't gotten around to doing it yet. The current version was a quick port of the old 1.7.10 version, with a few new mob (designed for a mod I was abandoning so they wouldn't got to waste).

But updating the mob drops to the new json based system is planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants