Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for Brillouin.jl #248

Closed
kbarros opened this issue Mar 16, 2024 · 1 comment · Fixed by #328
Closed

Better support for Brillouin.jl #248

kbarros opened this issue Mar 16, 2024 · 1 comment · Fixed by #328
Labels
enhancement New feature or request

Comments

@kbarros
Copy link
Member

kbarros commented Mar 16, 2024

The package Brillouin.jl conveniently reports high-symmetry k-points and paths. This is especially useful when the user specifies the chemical cell in a nonconventional way.

In the special case where a Sunny.Crystal has complete chemical information, example usage looks like this:

using Brillouin, Spglib
kp = irrfbz_path(Spglib.Cell(cryst.latvecs, cryst.positions, cryst.types))

Which outputs:

KPath{3} (6 points, 3 paths, 12 points in paths):
 points: :M => [0.5, 0.0, 0.0]
         :A => [0.0, 0.0, 0.5]
         :H => [0.333333, 0.333333, 0.5]
         :K => [0.333333, 0.333333, 0.0]
         :Γ => [0.0, 0.0, 0.0]
         :L => [0.5, 0.0, 0.5]
  paths: [:Γ, :M, :K, :Γ, :A, :L, :H, :A]
         [:L, :M]
         [:H, :K]
   ...

We should make it easier and more robust. Two options:

  1. Crystal could store the internally built Spglib.Cell to facilitate integration with Brillouin.jl on the user side.
  2. If we're willing to make Brillouin.jl a dependency, then Crystal could directly store the special k-points directly.
@kbarros
Copy link
Member Author

kbarros commented Nov 12, 2024

Will be implemented in #328.

@kbarros kbarros added the enhancement New feature or request label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant