Downloader: Asynchronous downloading to memory, apply to release checker
#3038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vankata453
added
type:feature
category:code
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transferis now a base class for two new derived classes:FileTransferandStringTransfer.FileTransferhas the same functionality whichTransferhad before - it writes received data to a file.StringTransfer, however, appends received data to a referenced string. These additions are also supported by WASM (NOTE: Needs to be tested).A
StringTransfer, which is requested by callingDownloader::request_string_download(), is now used for downloading the "supertux-versioninfo" file, used by the in-game release checker.Additionally:
AddonManagerone, by providing a pointer to the currentDownloader(NOTE: Needs to be tested).TransferStatusLists has been added to allDownloaderfunctions.ReaderDocumentnow contains thefrom_string()static function, which is a convenience wrapper aroundfrom_stream(), where a stream, which only has the given string in its buffer, is provided.Closes #2627.