Sending multiple requests in quick succession sends to same number

[prestonvanloon]

If you send multiple requests quickly, they overwrite the options with the receiver.

Expected: Send three requests to send message with a receiver field different phone numbers. Messages are sent to three different numbers.

Observed behavior: the message is sent three times to same number.

Here is the offending code where the request shares / reuses the same options by copying the pointer to the options.

promtotwilio/options_with_handler.go

Line 54 in d63336c

sendOptions := m.Options

The service needs a mutex around this option or make a deep copy of the options before mutating it.

[prestonvanloon]

Here's the simplest way to understand the problem: https://play.golang.org/p/rZyz-ivCnch

[prestonvanloon]

And here's a simple fix to that example: https://play.golang.org/p/_NLLKtaP0mv