[Maintenance] Add TwigToPdfGenerator #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldic3
force-pushed
the
refactor/twig-to-pdf-generator
branch
2 times, most recently
from
8150936
to
100c9f2
Compare
coldic3
added
Maintenance
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
GSadee
force-pushed
the
refactor/twig-to-pdf-generator
branch
from
100c9f2
to
796972a
Compare
GSadee
reviewed
Apr 4, 2022
coldic3
force-pushed
the
refactor/twig-to-pdf-generator
branch
2 times, most recently
from
c1da48e
to
27c7019
Compare
coldic3
force-pushed
the
refactor/twig-to-pdf-generator
branch
from
27c7019
to
19051ee
Compare
GSadee
approved these changes
Apr 4, 2022
Roshyo
approved these changes
Apr 6, 2022
|
Thanks, Kevin! 🥇 |
GSadee
added a commit
to Sylius/InvoicingPlugin
that referenced
this pull request
Apr 19, 2022
This PR was merged into the 1.0-dev branch. Discussion ---------- To keep both InvoicingPlugin and RefundPlugin consistent on how PDF is generated, in this PR, I did a similar refactor to this one: Sylius/RefundPlugin#362. Commits ------- 9598b79 [Maintenance] Add TwigToPdfGenerator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would give developers an easier replacement of the pdf generator if required.