Add missing csrf_token field #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubtobiasz
force-pushed
the
fix/missing-csrf-token
branch
from
3b779aa
to
469fde9
Compare
GSadee
reviewed
Nov 7, 2022
jakubtobiasz
force-pushed
the
fix/missing-csrf-token
branch
2 times, most recently
from
53aacf2
to
540b68c
Compare
jakubtobiasz
force-pushed
the
fix/missing-csrf-token
branch
from
540b68c
to
1dd2174
Compare
GSadee
approved these changes
Nov 8, 2022
| public function __construct( | ||
| MessageBusInterface $commandBus, | ||
| Session $session, | ||
| UrlGeneratorInterface $router, | ||
| RefundUnitsCommandCreatorInterface $commandCreator, | ||
| LoggerInterface $logger | ||
| LoggerInterface $logger, | ||
| CsrfTokenManagerInterface $csrfTokenManager, |
There was a problem hiding this comment.
As you were adding a new argument, you could use constructor property promotion here:
Suggested change
| CsrfTokenManagerInterface $csrfTokenManager, | |
| private CsrfTokenManagerInterface $csrfTokenManager, |
|
Thank you, Jakub! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few of our plugins, we have included this change manually, so this PR fixes this.