Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add availibility check for product #648

Closed
wants to merge 1 commit into from
Closed

Add availibility check for product #648

wants to merge 1 commit into from

Conversation

alexander-schranz
Copy link
Contributor

fixes #594

TODO:

  • Tests

@alexander-schranz alexander-schranz force-pushed the feature/availability-product-variant branch 3 times, most recently from 1258f60 to d3b2357 Compare May 20, 2020 10:42
@alexander-schranz alexander-schranz mentioned this pull request May 25, 2020
Open
@alexander-schranz alexander-schranz force-pushed the feature/availability-product-variant branch from d3b2357 to 2d5157f Compare May 27, 2020 14:00
@lchrusciel lchrusciel added the Bug label Jun 1, 2020
@mamazu
Copy link
Member

mamazu commented Feb 21, 2021

Is this pull request still active or should I take it?

@alexander-schranz
Copy link
Contributor Author

@mamazu feel free to take it over!

@mamazu mamazu mentioned this pull request Feb 21, 2021
Merged
@mamazu
Copy link
Member

mamazu commented Feb 21, 2021

Replaced by #701

@mamazu mamazu closed this Feb 21, 2021
lchrusciel added a commit that referenced this pull request Feb 23, 2021
@lchrusciel
feature #701 Availability product variant (alexander-schranz, mamazu)
1e105c6 
This PR was merged into the 1.0-dev branch.

Discussion
----------

Replaces #648

Commits
-------

2d5157f Add availibility check for product
236dbed Adding availablity checker in a non bc-breaking way
72e19d5 Fixing the tests
db1e5d7 Reverting back useless changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why don't perform availability check when add item to cart
3 participants
@alexander-schranz @mamazu @lchrusciel