[Doc] fix checkoutState parameter in PlacedOrder swagger definition
#611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think displaying order's state would be useful for some, though. Do you think we should add it to the view? I could work on implementation in other PR. |
|
The default state is probably |
lchrusciel
approved these changes
Jan 16, 2020
Co-Authored-By: Łukasz Chruściel <[email protected]>
mamazu
approved these changes
Jan 16, 2020
|
Thanks, Emil! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the intention here was to display order's state (then the enum would be correct), but in fact checkout state is returned as in
Cartdefinition.Note that the checkout state will always be
completedfor placed orders.