-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect Address Book and me routes #616
Conversation
Thank you for your pull request. One thing I was woundering when looking through the documentation is: In the docs it says that the endpoint returns a 500 if the user does not own the address. If this behaviour has also changed then could you please update the documentation and add a note in the |
@mamazu Thanks for review , I have updated the docs and the upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Could you please rebase your pull request to the current master and also add the authorization documentation to the new "change password route"? |
@mamazu Sure I will do that |
c49acd3
to
9422e0e
Compare
@mamazu I have rebased the master , I checked the change password route in docs , the new protection will match with new route docs , It will return 401 |
I don't really get why the address book routes return a 404 when the customer does not have access to those routes instead of a 403 but as this seems to be Sylius default I am okay with it. |
Thanks, Amr! 🎉 |
Protect Address book and me routes in security.yaml
related issues #569