Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the note about ShopBundle conflict more visible #642

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Make the note about ShopBundle conflict more visible #642

merged 1 commit into from
Apr 9, 2020

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Apr 8, 2020

No description provided.

@Roshyo Roshyo requested a review from a team as a code owner April 8, 2020 15:18
lchrusciel
lchrusciel approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be quite important, indeed.

Thanks a lot for this PR.

@lchrusciel lchrusciel merged commit 8aad18b into Sylius:master Apr 9, 2020
@lchrusciel
Copy link
Member

Thank you, Stephane! 🥇

@Roshyo Roshyo deleted the patch-1 branch April 9, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Roshyo @lchrusciel