Drop Symfony 4.4 support #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMilek
force-pushed
the
drop-symfony-4.4
branch
3 times, most recently
from
db7282e
to
21615b3
Compare
TheMilek
force-pushed
the
drop-symfony-4.4
branch
4 times, most recently
from
f8f393f
to
4a22c5d
Compare
TheMilek
force-pushed
the
drop-symfony-4.4
branch
4 times, most recently
from
2db2dd8
to
6202788
Compare
TheMilek
force-pushed
the
drop-symfony-4.4
branch
from
6202788
to
1d02997
Compare
TheMilek
changed the title
GSadee
approved these changes
Jan 5, 2023
| mysql: [5.7, 8.0] | ||
| symfony: [^4.4, ~5.2.0, ~5.3.0] | ||
| symfony: [^5.2] |
There was a problem hiding this comment.
With this provision, we are only testing 5.4 anyway, but as those versions (Sf 5.2 and 5.3) have not been supported for at least a year anyway, I think we can remove support for them clearly, as we did in Sylius 1.11
|
Thank you, Kamil! 🥇 |
GSadee
added a commit
that referenced
this pull request
Jan 9, 2023
This PR was merged into the 1.6 branch. Discussion ---------- Changes: - Dropped `symfony/web-server-bundle` as is no longer supported by Symfony - Bumped up the `phpstan/phpstan` to 1.8 version and `phpstan/phpstan-webmozart-assert` to 1.2 - Updated `.env.dist` files to make them usable with the available documentation **Important!** To potential merge after merging #735 and #737 Commits ------- 8657ed0 Support Sylius 1.12 8886e5e Update and fix PHPStan ee2bd38 Remove redundant test 9387a1d fix .env files e93b51d Fix Contract tests and ECS 0d7bd21 [PHPUnit] improve checking both swiftmailer and symfony mailer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will no more support Symfony 4.4