Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer.lock shall be removed from .gitignore #947

Open
chrodriguez opened this issue Feb 9, 2024 · 0 comments
Open

composer.lock shall be removed from .gitignore #947

chrodriguez opened this issue Feb 9, 2024 · 0 comments

Comments

@chrodriguez
Copy link

Hello, I've followed the instructions for installing sylius standard in development mode. It suggests to clone this repo (or creating your own based on this template).

When you are working with docker, the lifecycle will not consider creating a project using composer, like:

 php composer.phar create-project sylius/sylius-standard project

Instead,the first command a developer would run is (considering some ad-hoc modifications considering developers operating system to docker-compose):

docker-compose up

Without composer workflow, post-create-project-cmd will never be called, and composer.lock will be always ignored. Issue #665 and PR 855 fixes this problem when working with composer, but I think removing line 19 of .gitignore would be a better approach.

I would like to create a PR, but first I would like to know If there is any reason to keep this file ignored in this repo as it is not a composer library, and composer itself recommends to version composer.lock file.

Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant