-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaling text input field to keep enough room for the buttons #10164
Scaling text input field to keep enough room for the buttons #10164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm totally 👍 looking at the result (it's obviously better 😄), but I would also like to see the opinion of someone more fluent with CSS if we do not violent any convention/rules cc @kulczy
@4c0n thanks for that! Just a small tip, |
@Zales0123 Thanks! |
@4c0n I think the best option would be to extend semantic to handle auto-width columns, we'll probably do it in the future. And for now, your arguments sound good to me 👍 |
Thank you, Youri! 🥇 |
When using some languages the buttons break out the search segment, because the text on them is longer than what can fit in the semantic ui determined column size.
This change makes sure that the buttons always get enough room, by scaling the size of the text input field. Without breaking the layout.
To test this or reproduce the original behavior:
/nl/taxons/<dutch_taxon_slug>
route you will find that the layout is broken.