[maintenance][js]Specify engines dependencies #13956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferror
force-pushed
the
maintanance-node-engine
branch
from
4373669
to
f0676f3
Compare
lchrusciel
reviewed
May 12, 2022
lchrusciel
added
Enhancement
|
Thank you, Zbigniew! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on documentation: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#engines
I would like to propose adding the Node engine to the package.json as we currently maintain and test Sylius on 14 and 16 versions. We do the exactly the same thing with the PHP version.