[Symfony 6] Enable authenticator manager #14283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ernestWarwas
commented
Sep 7, 2022
ernestWarwas
commented
| Q | A |
|---|---|
| Branch? | 1.12 |
| Bug fix? | yes (For Symfony 6) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | relates to #14162 |
| License | MIT |
probot-autolabeler
bot
added
API
GSadee
added a commit
that referenced
this pull request
Sep 14, 2022
…oic425, Zales0123) This PR was merged into the symfony-6 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | symfony-6 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | replaces #14183, contributes to #13274 | | License | MIT | The goal of this PR is to make the whole Sylius installable (not working yet!) with Symfony 6 packages. Packages builds are already working after #14287, #14284 and #14285. The next steps would be fixing static checks and PHPSpec, Behat tests are waiting for #14283 🖖 Commits ------- 7686374 Use UserNotFound exception 140d2ac Checking package versions f0c6234 Fix packages versions bbf077c Fix packages versions for doctrine/dbal a436cbb Upgrade main packages to allow Symfony 6 ef011a5 Do not remove conflict but adjust versions 88215a9 Bump knplabs/gaufrette dependency a36895f Delete unneeded swiftmailer file 1369d6e Hot-fix with symfony mockery container dc92fa2 Bump mailer bundle dependencies ef390c1 Make all dependencies consistent e5e4e16 Update some Sylius packages dependencies 49aadc8 Remove unneedd conflicts
ernestWarwas
force-pushed
the
enable-authenticator-manager
branch
from
d2f87ad
to
60d87f3
Compare
This was referenced Sep 15, 2022
Closed
coldic3
approved these changes
Sep 15, 2022
src/Sylius/Bundle/CoreBundle/Validator/Constraints/UniqueReviewerEmailValidator.php
Show resolved
Hide resolved
GSadee
reviewed
Sep 15, 2022
src/Sylius/Bundle/CoreBundle/Validator/Constraints/UniqueReviewerEmailValidator.php
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/EventListener/ApiCartBlamerListener.php
Outdated
Show resolved
Hide resolved
probot-autolabeler
bot
added
the
Maintenance
ernestWarwas
force-pushed
the
enable-authenticator-manager
branch
from
4ae19ae
to
6f763ad
Compare
NoResponseMate
approved these changes
Sep 15, 2022
Revert lexik guard for api Commented scenario for test purposes Test if set token to null fixes the scenario spec fix
[Events] Fixed cart blamin in API [Spec] Fix for spec ShopCartBlamerListener reverted
UPGRADE file updated and review changes fix services
ernestWarwas
force-pushed
the
enable-authenticator-manager
branch
from
4c05e9b
to
5d9ad1e
Compare
coldic3
approved these changes
Sep 15, 2022
Comment on lines
+43
to
+75
| ```diff | ||
| security: | ||
| - always_authenticate_before_granting: true | ||
| + enable_authenticator_manager: true | ||
| ``` | ||
|
|
||
| and you need to adjust all of your firewalls like that: | ||
|
|
||
| ```diff | ||
| admin: | ||
| # ... | ||
| form_login: | ||
| # ... | ||
| - csrf_token_generator: security.csrf.token_manager | ||
| + enable_csrf: true | ||
| # ... | ||
| new_api_admin_user: | ||
| # ... | ||
| - anonymous: true | ||
| + entry_point: jwt | ||
| # ... | ||
| - guard: | ||
| # ... | ||
| + jwt: true | ||
| ``` | ||
|
|
||
| and also you need to adjust all of your access_control like that: | ||
|
|
||
| ```diff | ||
| - - { path: "%sylius.security.admin_regex%/forgotten-password", role: IS_AUTHENTICATED_ANONYMOUSLY } | ||
|
|
||
| + - { path: "%sylius.security.admin_regex%/forgotten-password", role: PUBLIC_ACCESS } | ||
| ``` |
There was a problem hiding this comment.
In that way, pluses and minuses in diff blocks may not be properly highlighted in the markdown file. It's not a big deal but just wanted to mention it ;)
GSadee
approved these changes
Sep 15, 2022
|
Thanks, Ernest! 🎉 |
Zales0123
referenced
this pull request
Sep 20, 2022
… in security.yaml (GSadee) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12| | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no| | Related tickets | fixes https://github.com/Sylius/Sylius/pull/14283| | License | MIT | As it does not look like a diff now: <img width="1032" alt="image" src="https://user-images.githubusercontent.com/6140884/190562242-90b5d014-bc11-48b2-a6df-9b76fb500e45.png"> <!-- - Bug fixes must be submitted against the 1.11 branch - Features and deprecations must be submitted against the 1.12 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- c577356 [Maintenance] Improve note in UPGRADE file about changes in security.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.