Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] Fix setting sylius_ui.use_webpack parameter #14361

Merged
merged 1 commit into from
Sep 27, 2022
Merged

[Maintenance] Fix setting sylius_ui.use_webpack parameter #14361

merged 1 commit into from
Sep 27, 2022

Conversation

jakubtobiasz
Copy link
Contributor

Q A
Branch? 1.12
Bug fix? yes, but only affects 1.12
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #X, partially #Y, mentioned in #Z
License MIT

Previous way how we've been handling configuring sylius_ui.use_webpack was causing bugs e.g. on our demo.

@jakubtobiasz jakubtobiasz requested a review from a team as a code owner September 27, 2022 08:25
@GSadee GSadee added Maintenance CI configurations, READMEs, releases, etc. Bug Confirmed bugs or bugfixes. labels Sep 27, 2022
@GSadee GSadee merged commit ab7004e into Sylius:1.12 Sep 27, 2022
@GSadee
Copy link
Member

GSadee commented Sep 27, 2022

Thank you, Jakub! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@Rafikooo Rafikooo Rafikooo approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakubtobiasz @GSadee @NoResponseMate @Rafikooo