Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in PayumController #9464

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Fixed typo in PayumController #9464

merged 1 commit into from
Jun 8, 2018

Conversation

qkdreyer
Copy link
Contributor

@qkdreyer qkdreyer commented Jun 7, 2018 •
edited
Loading

Renamed resolveNextRouteRequestFacotry to resolveNextRouteRequestFactory

Q A
Branch? 1.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets mentioned in Sylius/SyliusPayumBundle#2
License MIT

@pamil
Copy link
Contributor

pamil commented Jun 7, 2018

Thank you a lot! Could you rebase it to 1.0 branch?

@pamil pamil added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Jun 7, 2018
@qkdreyer
Fixed typo in PayumController
d5131d1 
Renamed resolveNextRouteRequestFacotry to resolveNextRouteRequestFactory
@qkdreyer qkdreyer changed the base branch from master to 1.0 June 7, 2018 12:47
@qkdreyer
Copy link
Contributor Author

qkdreyer commented Jun 7, 2018

Done :)

@pamil pamil closed this Jun 7, 2018
@pamil pamil reopened this Jun 7, 2018
@pamil
Copy link
Contributor

pamil commented Jun 7, 2018

Just retriggering the CI build :)

@qkdreyer
Copy link
Contributor Author

qkdreyer commented Jun 8, 2018

Don’t forget to merge this :)

@Zales0123 Zales0123 merged commit 4ef14f7 into Sylius:1.0 Jun 8, 2018
@Zales0123
Copy link
Member

Thank you Quentin!

@qkdreyer qkdreyer deleted the patch-1 branch March 8, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qkdreyer @pamil @Zales0123