[RFC] Add success flashes before post event #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
reviewed
Aug 14, 2019
Zales0123
force-pushed
the
add-success-flashes-before-post-event
branch
from
35962df
to
927ae81
Compare
lchrusciel
reviewed
Aug 22, 2019
Zales0123
force-pushed
the
add-success-flashes-before-post-event
branch
from
927ae81
to
dff8261
Compare
Zales0123
added
RFC
lchrusciel
approved these changes
Sep 22, 2019
pamil
approved these changes
Oct 4, 2019
|
Thanks, Mateusz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know is it intended behavior or not 🤔 For me, a natural place to throw a post event is just before redirect. With this change, we can, for example, operate on flashed basing on create/updated/deleted resource data (I had such a case 💃)