Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doctrine extensions version on component #304

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Fix doctrine extensions version on component #304

merged 1 commit into from
Apr 8, 2021

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Apr 7, 2021

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner April 7, 2021 08:13
@loic425
Copy link
Member Author

loic425 commented Apr 7, 2021

@pamil Can you review this quickly ? This is blocking for Monofony to add PHP 8 support.

"don't install one of gedmo/doctrine-extensions[v2.4.42]"

@loic425
Copy link
Member Author

loic425 commented Apr 8, 2021

@pamil Please, this is the last step to add PHP 8 support on Monofony...
https://github.com/Monofony/Monofony/runs/2295638071

@pamil pamil merged commit 861d418 into Sylius:master Apr 8, 2021
@pamil
Copy link
Contributor

pamil commented Apr 8, 2021

Thanks, Loïc! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic425 @pamil