Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form attribute on SyliusCrudRoute #403

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Apr 4, 2022

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

It's a missing feature between yaml and attributes routes.

<?php 

#[SyliusRoute(
    name: 'register',
    path: '/users/register',
    methods: ['GET', 'POST'],
    controller: 'app.controller.user:createAction',
    form: RegisterType::class
)]
class User

@loic425 loic425 requested a review from a team as a code owner April 4, 2022 14:05
composer.json Outdated Show resolved Hide resolved
@loic425 loic425 force-pushed the feature/add-form-on-sylius-route branch from 8f21658 to d08ee33 Compare April 7, 2022 09:34
@Zales0123 Zales0123 added the Feature New feature proposals. label Apr 7, 2022
@Zales0123 Zales0123 merged commit 44e263c into Sylius:master Apr 7, 2022
@Zales0123
Copy link
Member

Thank you, Loïc! 🥇

@loic425 loic425 deleted the feature/add-form-on-sylius-route branch April 7, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants